-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make which quantities are sampled more readily configurable #326
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 24.47% 27.69% +3.22%
==========================================
Files 22 24 +2
Lines 1704 1755 +51
==========================================
+ Hits 417 486 +69
+ Misses 1287 1269 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about an approach that parsed the model name? We already use model_name
as an argument to many functions in the pipeline.
Per F2F discussion, the model name approach will not be taken in this PR. In the future, we could implement is and make use of the switches approach implemented in this PR. |
This PR creates a clearer interface for configuring what quantities are sampled during fitting and posterior prediction. This will make it easier to use the same infrastructure for the various Pyrenew-{H,E,W} combinations.
To do: