-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wastewater data to pyrenew_hew_data #317
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 24.47% 27.06% +2.59%
==========================================
Files 22 23 +1
Lines 1704 1836 +132
==========================================
+ Hits 417 497 +80
- Misses 1287 1339 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good, thanks @sbidari! A few questions and suggestions.
Co-authored-by: Dylan H. Morris <[email protected]>
Ready for re-review! @damonbayer @dylanhmorris |
Added
prep_ww_data.py
: extracting, cleaning, and preprocessing NWSS data.Updated
prep_data.py
: incorporate wastewater data into the training data.Updated
pyrenew_hew_data.py
: downstream processing of wastewater data.Added a test in
test_pyrenew_hew_data.py
Misc:
Renamed some variables in the wastewater model for clarity.
Standardized date handling using
datetime.date
.To do: Update path for NWSS data