Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wastewater data to pyrenew_hew_data #317

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jan 31, 2025

Added prep_ww_data.py: extracting, cleaning, and preprocessing NWSS data.
Updated prep_data.py: incorporate wastewater data into the training data.
Updated pyrenew_hew_data.py: downstream processing of wastewater data.
Added a test in test_pyrenew_hew_data.py
Misc:
Renamed some variables in the wastewater model for clarity.
Standardized date handling using datetime.date.

To do: Update path for NWSS data

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 63.19444% with 53 lines in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (c6e0fc1) to head (eb61c98).

Files with missing lines Patch % Lines
pipelines/prep_ww_data.py 18.18% 36 Missing ⚠️
pyrenew_hew/pyrenew_hew_data.py 86.17% 13 Missing ⚠️
pipelines/build_pyrenew_model.py 0.00% 2 Missing ⚠️
pipelines/prep_data.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   24.47%   27.06%   +2.59%     
==========================================
  Files          22       23       +1     
  Lines        1704     1836     +132     
==========================================
+ Hits          417      497      +80     
- Misses       1287     1339      +52     
Flag Coverage Δ
hewr 41.68% <ø> (ø)
pipelines 5.85% <20.00%> (+1.18%) ⬆️
pyrenew_hew 35.76% <86.17%> (+7.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review February 6, 2025 15:49
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good, thanks @sbidari! A few questions and suggestions.

pipelines/build_pyrenew_model.py Outdated Show resolved Hide resolved
pipelines/prep_data.py Show resolved Hide resolved
pipelines/prep_data.py Outdated Show resolved Hide resolved
pipelines/prep_ww_data.py Outdated Show resolved Hide resolved
pipelines/prep_ww_data.py Outdated Show resolved Hide resolved
pipelines/prep_ww_data.py Outdated Show resolved Hide resolved
pipelines/prep_ww_data.py Outdated Show resolved Hide resolved
pipelines/prep_ww_data.py Outdated Show resolved Hide resolved
pyrenew_hew/pyrenew_hew_data.py Outdated Show resolved Hide resolved
pyrenew_hew/pyrenew_hew_data.py Outdated Show resolved Hide resolved
@sbidari
Copy link
Collaborator Author

sbidari commented Feb 10, 2025

Ready for re-review! @damonbayer @dylanhmorris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants