add subpopulation to LatentInfectionProcess #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 15.87% 20.67% +4.79%
==========================================
Files 21 21
Lines 1537 1572 +35
==========================================
+ Hits 244 325 +81
+ Misses 1293 1247 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ynamics_modelpy-to-latentinfectiondynamics-class-in-pyrenew_hew_modelpy
There was a problem hiding this comment.
Looks very good, thanks @sbidari! A few minor questions/comments before approval
Co-authored-by: Dylan H. Morris <[email protected]>
|
I think changes from some other PR is causing the pipeline test and pre-commit to fail, but I have addressed the initial review comments. |
…ynamics_modelpy-to-latentinfectiondynamics-class-in-pyrenew_hew_modelpy
dylanhmorris
approved these changes
Jan 17, 2025
|
Thanks, @sbidari! |
dylanhmorris
deleted the
281-add-subpopulations-as-in-ww_site_level_dynamics_modelpy-to-latentinfectiondynamics-class-in-pyrenew_hew_modelpy
branch
damonbayer
added a commit
that referenced
this pull request
Jan 22, 2025
commit 724d09b Author: Dylan H. Morris <[email protected]> Date: Sat Jan 18 17:31:57 2025 +0000 Add helper data `PyrenewHEWData` class to hold input data to `PyrenewHewModel`s (#283) commit bc76d59 Author: Subekshya Bidari <[email protected]> Date: Fri Jan 17 14:18:11 2025 -0500 add subpopulation to LatentInfectionProcess (#282) commit a70e296 Author: Subekshya Bidari <[email protected]> Date: Wed Jan 15 15:29:44 2025 -0500 add setup-r (#295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #281
Adds subpopulation hierarchical dynamics to the
LatentInfectionProcessclass and corresponding tests.Also includes some clean-up and variable name changes in the
ww_site_level_dynamics_modelmodel.