-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add epiweekly other forecast samples to standard pipeline #270
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 18.46% 16.54% -1.93%
==========================================
Files 21 21
Lines 1446 1481 +35
==========================================
- Hits 267 245 -22
- Misses 1179 1236 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be merged if needed, but I think some of my comments are clear and easy improvements.
Co-authored-by: Damon Bayer <[email protected]>
…mode, update tests accordingly
Key changes
Pipeline now outputs two kinds of epiweekly proportion forecasts:
Pipeline automatically produces (and collates) plots of epiweekly aggregate predictions as well as daily-scale predictions, for better analysis of the actual forecast. For proportions, this includes both denominator options.
End to end test runs, and all plots are successfully collated.
to_epiweekly_quantile_table()
inhewr
now uses the pre-aggregated epiweekly trajectories rather than doing aggregation, and can be configured to use either of the two options (aggregated daily or directly forecast epiweekly) for the Other forecast.Out of scope
Incorporation of epiweekly plots into diagnostic report (should be done, separate issue imo)