Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priors to git repo and adjust container build #251

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Dec 16, 2024

Closes #238

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 7.96%. Comparing base (2927b03) to head (9ce2fbf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipelines/forecast_state.py 0.00% 28 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #251      +/-   ##
========================================
- Coverage   8.07%   7.96%   -0.11%     
========================================
  Files         20      20              
  Lines       1325    1343      +18     
========================================
  Hits         107     107              
- Misses      1218    1236      +18     
Flag Coverage Δ
hewr 22.02% <ø> (ø)
pipelines 0.00% <0.00%> (ø)
pyrenew_hew 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer marked this pull request as ready for review December 17, 2024 00:06
@damonbayer
Copy link
Collaborator Author

A bit unclear what's going on with the docker build.

It succeeded here, immediately after I introduced the COPY --exclude.

Then it started complaining about the exclude flag

Now it is succeeding after I added # syntax=docker/dockerfile:1.7-labs

@damonbayer
Copy link
Collaborator Author

Seems like the container build is reliably working now.

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @damonbayer

pipelines/forecast_state.py Outdated Show resolved Hide resolved
@damonbayer damonbayer merged commit 9884204 into main Dec 17, 2024
12 of 14 checks passed
@damonbayer damonbayer deleted the dmb_track_priors_in_git branch December 17, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add priors to git repo and adjust container build
2 participants