-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postprocessing collation helper, minor prod/util edits #250
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 19.57% 18.54% -1.04%
==========================================
Files 20 21 +1
Lines 1364 1440 +76
==========================================
Hits 267 267
- Misses 1097 1173 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes #163 ? |
Prerequisite but as written doesn't close because it's just a local helper for now and I didn't yet do anything with task dependencies for an azure prod job. My instinct is "land this and then do that as a separate PR", but lmk if you think otherwise. |
@damonbayer ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be possible to do a postprocess test in CI in this PR? I think that would put us in a really good position for making sure all the PyRenew-HE changes continue to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is still WIP, but formally requesting changes to address the CI failure.
…ke error messages when scoring not possible more informative
All CI now passes; ready for re-review @damonbayer (or @sbidari since @damonbayer is out). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a very thorough review but it looks mostly good to me!
postprocess_forecast_batches.py
to automate plot collation, hubverse table creation, etcutils.py
setup_prod_job.py
default to a job withCOVID-19
andInfluenza
as thediseases
postprocess_forecast_batches.py
to the end to end test, and make the end to end test try multiple locations x multiple diseases, including US national forecasts.