Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model_runs directory #136

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Add model_runs directory #136

merged 15 commits into from
Nov 20, 2024

Conversation

damonbayer
Copy link
Collaborator

This makes it easier to iterate over all the runs by calling dir_ls on model_runs and also makes it easier to locate collated plots and other files that apply to all the model runs.

@damonbayer
Copy link
Collaborator Author

Seems like the baseline forecasts are not being fit.

@SamuelBrand1
Copy link
Collaborator

Seems like the baseline forecasts are not being fit.

Are are we making updates to the structure without having a test run facility to check which parts of the code base are affected by any change?

@damonbayer
Copy link
Collaborator Author

@SamuelBrand1 #135 was supposed to help with that. It's not written as a formal test, but that is the plan in #126. Surprisingly, for this PR, it runs without throwing an error, even though the baseline forecasts aren't being fit.

@SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 #135 was supposed to help with that. It's not written as a formal test, but that is the plan in #126. Surprisingly, for this PR, it runs without throwing an error, even though the baseline forecasts aren't being fit.

That suggests that we want something to return this failure in part of the run?

@damonbayer
Copy link
Collaborator Author

@SamuelBrand1 #135 was supposed to help with that. It's not written as a formal test, but that is the plan in #126. Surprisingly, for this PR, it runs without throwing an error, even though the baseline forecasts aren't being fit.

This will be addressed in #143

@damonbayer damonbayer changed the base branch from main to 91-quantile-based-forecast-scoring November 19, 2024 20:59
@damonbayer damonbayer changed the base branch from 91-quantile-based-forecast-scoring to main November 19, 2024 21:00
damonbayer and others added 2 commits November 19, 2024 15:04
* Issue 137: unify argument patterns (#138)

* add check to all subprocess commands (#143)

* Organize helper functions / utilities (#141)

---------

Co-authored-by: Samuel Brand <[email protected]>
Co-authored-by: Dylan H. Morris <[email protected]>
@damonbayer
Copy link
Collaborator Author

The default "Files Changed" view is borked, but you can see the actual changes here.

@damonbayer damonbayer marked this pull request as ready for review November 19, 2024 23:01
@damonbayer
Copy link
Collaborator Author

damonbayer commented Nov 19, 2024

@dylanhmorris Ready for your review. Would appreciate some guidance on modification to the collation scripts.

Example results available in pyrenew-test-output/covid-19_r_2024-11-19_f_2024-08-16_t_2024-11-13/

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to keep things up to date and then this can land. Thanks @damonbayer!

pipelines/postprocess_state_forecast.R Outdated Show resolved Hide resolved
pipelines/timeseries_forecasts.R Show resolved Hide resolved
pipelines/timeseries_forecasts.R Outdated Show resolved Hide resolved
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @damonbayer!

@damonbayer damonbayer merged commit ba9e617 into main Nov 20, 2024
4 of 8 checks passed
@damonbayer damonbayer deleted the dmb_model_runs_2 branch November 20, 2024 19:06
damonbayer added a commit that referenced this pull request Nov 20, 2024
damonbayer added a commit that referenced this pull request Nov 20, 2024
Revert "Add `model_runs` directory (#136)"

This reverts commit ba9e617.
@damonbayer damonbayer restored the dmb_model_runs_2 branch November 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants