-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model_runs
directory
#136
Conversation
Seems like the baseline forecasts are not being fit. |
Are are we making updates to the structure without having a test run facility to check which parts of the code base are affected by any change? |
@SamuelBrand1 #135 was supposed to help with that. It's not written as a formal test, but that is the plan in #126. Surprisingly, for this PR, it runs without throwing an error, even though the baseline forecasts aren't being fit. |
That suggests that we want something to return this failure in part of the run? |
This will be addressed in #143 |
* Issue 137: unify argument patterns (#138) * add check to all subprocess commands (#143) * Organize helper functions / utilities (#141) --------- Co-authored-by: Samuel Brand <[email protected]> Co-authored-by: Dylan H. Morris <[email protected]>
The default "Files Changed" view is borked, but you can see the actual changes here. |
@dylanhmorris Ready for your review. Would appreciate some guidance on modification to the collation scripts. Example results available in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change to keep things up to date and then this can land. Thanks @damonbayer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @damonbayer!
This reverts commit ba9e617.
This makes it easier to iterate over all the runs by calling
dir_ls
onmodel_runs
and also makes it easier to locate collated plots and other files that apply to all the model runs.