Skip to content

Commit

Permalink
Workflow for building container image (#106)
Browse files Browse the repository at this point in the history
* Adding workflow

* Adding pyrenew back and setting runners to be cfa-cdcgov

* Update Containerfile.dependencies

Co-authored-by: Damon Bayer <[email protected]>

* Reverting python image

* Adding a tag to pyrenew dependency

* Adding pyrenew version as argument

* Adding pyrenew version as argument

* Trying a different alternative for build args

* Maybe is the new line?

* Build args as string

* Debugging pyrenew version

* Moving the location of the argument

* Switching to py 3.13

---------

Co-authored-by: Damon Bayer <[email protected]>
  • Loading branch information
gvegayon and damonbayer authored Nov 13, 2024
1 parent 81ad6f0 commit cb4609d
Show file tree
Hide file tree
Showing 3 changed files with 133 additions and 6 deletions.
119 changes: 119 additions & 0 deletions .github/workflows/containers.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
name: Create Docker Image

on:
pull_request:
workflow_dispatch:

env:
REGISTRY: cfaprdbatchcr.azurecr.io
IMAGE_NAME: pyrenew-hew
PYRENEW_VERSION: v0.1.1

jobs:

build-dependencies-image:
runs-on: cfa-cdcgov
name: Build dependencies image

outputs:
tag: ${{ steps.image-tag.outputs.tag }}
commit-msg: ${{ steps.commit-message.outputs.message }}

steps:

#########################################################################
# Retrieving the commit message
# We need to ensure we are checking out the commit sha that triggered the
# workflow, not the PR's head sha. This is because the PR's head sha may
# be a merge commit, which will not have the commit message we need.
#########################################################################
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Getting the commit message
id: commit-message
run: echo "message=$(git log -1 --pretty=%s HEAD)" >> $GITHUB_OUTPUT

- name: Checking out the latest (may be merge if PR)
uses: actions/checkout@v4

# From: https://stackoverflow.com/a/58035262/2097171
- name: Extract branch name
shell: bash
run: echo "branch=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> $GITHUB_OUTPUT
id: branch-name

#########################################################################
# Getting the tag
# The tag will be used for both the docker image and the batch pool
#########################################################################
- name: Figure out tag (either latest if it is main or the branch name)
id: image-tag
run: |
if [ "${{ steps.branch-name.outputs.branch }}" = "main" ]; then
echo "tag=latest" >> $GITHUB_OUTPUT
else
echo "tag=${{ steps.branch-name.outputs.branch }}" >> $GITHUB_OUTPUT
fi
- name: Check cache for base image
uses: actions/cache@v4
id: cache
with:
key: docker-dependencies-${{ runner.os }}-${{ hashFiles('./Containerfile.dependencies') }}-${{ steps.image-tag.outputs.tag }}
lookup-only: true
path:
./Containerfile.dependencies

- name: Login to the Container Registry
if: steps.cache.outputs.cache-hit != 'true'
uses: docker/login-action@v3
with:
registry: "cfaprdbatchcr.azurecr.io"
username: "cfaprdbatchcr"
password: ${{ secrets.CFAPRDBATCHCR_REGISTRY_PASSWORD }}

- name: Build and push
if: steps.cache.outputs.cache-hit != 'true'
uses: docker/build-push-action@v6
with:
push: true
no-cache: true
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-dependencies:${{ steps.image-tag.outputs.tag }}
file: ./Containerfile.dependencies
build-args: |
PYRENEW_VERSION=${{ env.PYRENEW_VERSION }}
build-pipeline-image:

name: Build pipeline image

needs: build-dependencies-image
runs-on: cfa-cdcgov

outputs:
tag: ${{ needs.build-dependencies-image.outputs.tag }}
commit-msg: ${{ needs.build-dependencies-image.outputs.commit-msg }}

steps:

- name: Login to the Container Registry
uses: docker/login-action@v3
with:
registry: "cfaprdbatchcr.azurecr.io"
username: "cfaprdbatchcr"
password: ${{ secrets.CFAPRDBATCHCR_REGISTRY_PASSWORD }}

- name: Build and push model pipeline image for Azure batch
id: build_and_push_model_image
uses: docker/build-push-action@v6
with:
push: true # This can be toggled manually for tweaking.
tags: |
${{ env.REGISTRY}}/${{ env.IMAGE_NAME }}:${{ needs.build-dependencies-image.outputs.tag }}
file: ./Containerfile
build-args: |
TAG=${{ needs.build-dependencies-image.outputs.tag }}
9 changes: 3 additions & 6 deletions Containerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
FROM python:3.12
ARG TAG=local

FROM cfaprdbatchcr.azurecr.io/pyrenew-hew-dependencies:${TAG}

RUN apt-get update
RUN apt-get install -y r-base
RUN apt-get install -y cmake
RUN pip install --root-user-action=ignore -U pip
RUN pip install --root-user-action=ignore git+https://github.com/cdcgov/pyrenew
COPY ./hewr ./pyrenew-hew/hewr

WORKDIR pyrenew-hew

Check warning on line 7 in Containerfile

View workflow job for this annotation

GitHub Actions / Build pipeline image

Relative workdir without an absolute workdir declared within the build can have unexpected results if the base image changes

WorkdirRelativePath: Relative workdir "pyrenew-hew" can have unexpected results if the base image changes More info: https://docs.docker.com/go/dockerfile/rule/workdir-relative-path/
Expand Down
11 changes: 11 additions & 0 deletions Containerfile.dependencies
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
FROM python:3.13

ARG PYRENEW_VERSION=v0.1.1

RUN apt-get update
RUN apt-get install -y r-base
RUN apt-get install -y cmake
RUN pip install --root-user-action=ignore -U pip
RUN pip install --root-user-action=ignore git+https://github.com/cdcgov/pyrenew.git@$PYRENEW_VERSION

CMD ["bash"]

0 comments on commit cb4609d

Please sign in to comment.