Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daily data filename #17438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

adegolier
Copy link
Collaborator

This PR ...

Fixes an issue where the delivery history endpoint was generating filenames with identical timestamps as the last substring before the extension instead of returning the filenames sent to the receiver. It was additionally requested that this change include modifying the query to not join the action table as that appears to sometimes take a very long time to return.

Test Steps:

  1. Make a call to the /v1/waters/org/{organization}/deliveries endpoint on main.
  2. Note the filenames returned all end with an identical timestamp.
  3. Make the same call on this branch.
  4. Note the filenames returned no longer end with an identical timestamp.
  5. If you want to go the extra mile, verify that the filenames returned match the external_name field for the send step.

Changes

  • Modified DSL used to create the query that pulls delivery history to only use the send step and determine this only using the report_file table as well as pull the filename from the external_name field
  • Updated the test to match the external filename instead of a generated name.

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Updated tests?

Linked Issues

@adegolier adegolier added the platform Platform Team label Feb 25, 2025
@adegolier adegolier requested a review from a team as a code owner February 25, 2025 18:23
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

1 287 tests  ±0   1 283 ✅ ±0   7m 43s ⏱️ -17s
  168 suites ±0       4 💤 ±0 
  168 files   ±0       0 ❌ ±0 

Results for commit ead79e7. ± Comparison against base commit aef18c0.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

Integration Test Results

 60 files  ±0   60 suites  ±0   44m 5s ⏱️ +20s
428 tests ±0  418 ✅ ±0  10 💤 ±0  0 ❌ ±0 
431 runs  ±0  421 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit ead79e7. ± Comparison against base commit aef18c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Daily data filename is incorrect
2 participants