Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Hikari connection timeout to 60 seconds #17429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arnejduranovic
Copy link
Collaborator

This PR fixes a bug where Hikari config was not respecting the value of 60000ms for the connection timeout. It is also the hope that this change helps address the issue described in the following incident report: https://cdc.sharepoint.com/:w:/r/teams/ReportStream/_layouts/15/Doc.aspx?sourcedoc=%7B2E1169CA-B921-4CAA-B0E6-2BEF7443A1D7%7D&file=2025_02_18%20-%20Database%20Connectivity%20Issues.docx&action=default&mobileredirect=true

Test Steps:

  1. Start up the app and verify the hikari config has the connection timeout property set to 60000 on this branch and 30000 on main:
    Screenshot 2025-02-24 at 1 10 35 PM

@arnejduranovic arnejduranovic requested a review from a team as a code owner February 24, 2025 19:15
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

1 280 tests  ±0   1 276 ✅ ±0   7m 48s ⏱️ +19s
  168 suites ±0       4 💤 ±0 
  168 files   ±0       0 ❌ ±0 

Results for commit 5a05cb8. ± Comparison against base commit a06f23e.

Copy link
Contributor

Integration Test Results

 60 files  ±0   60 suites  ±0   45m 11s ⏱️ + 2m 25s
428 tests ±0  418 ✅ ±0  10 💤 ±0  0 ❌ ±0 
431 runs  ±0  421 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 5a05cb8. ± Comparison against base commit a06f23e.

@arnejduranovic arnejduranovic added the platform Platform Team label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant