Enable Hikari connection timeout to be set via environment variable #17425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
arnejduranovic
temporarily deployed
to
staging
GitHub Actions
Inactive
arnejduranovic
temporarily deployed
to
staging
GitHub Actions
Inactive
arnejduranovic
commented
Feb 24, 2025
| @@ -1414,10 +1415,7 @@ class DatabaseAccess(val create: DSLContext) : Logging { | |||
| config.addDataSourceProperty("cachePrepStmts", "true") | |||
| config.addDataSourceProperty("prepStmtCacheSize", "250") | |||
| config.addDataSourceProperty("prepStmtCacheSqlLimit", "2048") | |||
| config.addDataSourceProperty( | |||
There was a problem hiding this comment.
This code was setting connection timeout to 60sec but in staging and prod the effective timeout was 30 seconds. So, I deleted this chunk of code and set the connection timeout via the connectionTimeout property, hoping this will fix the issue.
See the incident report linked in the PR description for more details.
| @@ -102,6 +103,11 @@ val dbUrl = ( | |||
| ?: System.getenv(KEY_DB_URL) | |||
| ?: "jdbc:postgresql://localhost:5432/prime_data_hub" | |||
| ) as String | |||
| val hikariConfigTimeout = ( | |||
There was a problem hiding this comment.
default to 60 seconds if not set in env var
|
devopsmatt
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates application code, gradle, and terraform to allow the hikari connection timeout to be set via environment variable. This also fixes a bug where the configured connection timeout was not being respected.
Test Steps:
0. @devopsmatt to verify and validate TF changes
Changes