Tf deplotment changes #17093
Merged
Tf deplotment changes #17093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devopsmatt
reviewed
Jan 17, 2025
| terraform fmt -recursive | ||
| terraform plan -out=tf.plan | ||
| - name: Run Terraform Apply | ||
| run: | |
There was a problem hiding this comment.
Looks good, just one thing - I think this apply step should be conditional on the plan step, using needs: ...
devopsmatt
reviewed
Jan 17, 2025
There was a problem hiding this comment.
I think this file doesn't need modifications, we should exclude it from the PR.
devopsmatt
reviewed
Jan 17, 2025
.github/workflows/0
Outdated
There was a problem hiding this comment.
I think this was included in the commit by mistake/typo, it should not be in this PR.
devopsmatt
reviewed
Jan 17, 2025
There was a problem hiding this comment.
There's something wrong here, this file does not need modifications and doesn't need to be in this PR.
bethbeza
force-pushed
the
tf-deplotment-changes
branch
from
6ce25bb to
ec92b67
Compare
devopsmatt
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Places tf plan and apply in its corrected place.