Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform/david navapbc/15514/hl7 oml aui fhir mapping #16619

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Platform/david navapbc/15514/hl7 oml aui fhir mapping #16619

wants to merge 14 commits into from

Conversation

david-navapbc
Copy link
Collaborator

This PR ...

adds mapping for HL7/IN1/AUI to HL7/OML and AUIExtension test

Testing

  • [ x] Tested locally?
  • [ x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • [ x] Added tests?

@david-navapbc david-navapbc requested a review from a team as a code owner November 20, 2024 23:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Test Results

1 248 tests  +1   1 244 ✅ +1   7m 33s ⏱️ +18s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit 29325b1. ± Comparison against base commit f0972f3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Integration Test Results

 56 files   56 suites   28m 50s ⏱️
416 tests 405 ✅ 10 💤 1 ❌
419 runs  408 ✅ 10 💤 1 ❌

For more details on these failures, see this check.

Results for commit 29325b1.

♻️ This comment has been updated with latest results.

@JFisk42 JFisk42 self-assigned this Nov 21, 2024
@JFisk42 JFisk42 added the platform Platform Team label Nov 21, 2024
JFisk42
JFisk42 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@JFisk42 JFisk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments relating to formatting/project convention following, otherwise this was great work!

prime-router/metadata/HL7/catchall/hl7/message/OML_O21.yml Outdated Show resolved Hide resolved
...uter/src/testIntegration/kotlin/datatests/mappinginventory/catchall/aui/AUIExtensionTests.kt Outdated Show resolved Hide resolved
prime-router/src/testIntegration/resources/datatests/mappinginventory/catchall/oml/oml.hl7 Outdated Show resolved Hide resolved
prime-router/src/testIntegration/resources/datatests/mappinginventory/catchall/aui/aui.hl7 Outdated Show resolved Hide resolved
prime-router/metadata/HL7/catchall/hl7/segments/IN1/Coverage.yml Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 23, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFisk42 JFisk42 JFisk42 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@JFisk42 JFisk42

Labels
platform Platform Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-navapbc @JFisk42