16394 add ack functionality #16552
Open
16394 add ack functionality #16552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jalbinson
commented
Nov 15, 2024
| val ackMsh = outgoingAck.msh | ||
| ackMsh.msh1_FieldSeparator.value = "|" | ||
| ackMsh.msh2_EncodingCharacters.value = "^~\\&" | ||
| ackMsh.msh3_SendingApplication.parse("ReportStream") |
There was a problem hiding this comment.
I took these values directly from the Spec document so just double check that these are exactly what we want.
JFisk42
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks good and works well. I tested a few different scenarios: different message types (ORU), missing fields that should populate certain values in the response (MSH.3/MSH.4), and setting MSH.15 to AL when a fully populated message is sent. In each scenario the ACK response was correctly populated.
|
|
@arnejduranovic
|
…portstream into platform/jamie/16394-ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ACK functionality to the waters and report submission endpoints.
Test Steps:
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?Linked Issues