Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16307 orm and oml java classes #16549

Open
wants to merge 9 commits into
base: OML-Updates-Base
Choose a base branch
from

Conversation

jack-h-wang
Copy link
Collaborator

@jack-h-wang jack-h-wang commented Nov 15, 2024

This PR adds OML_O21 and ORM_O01 catchall Java classes. Some ORU_R01 classes have also been updated where new classes were applicable.

Test Steps:

  1. Ensure all test suites pass.

Changes

  • Add OML_O21 classes
  • Add ORM_O01 classes
  • Update ORU_R01 classes
  • Remove dependency on HAPI v2.6 classes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Linked Issues

To Be Done

This is the final PR to be merged into OML-Updates-Base before we begin the process of merging to main.

@jack-h-wang jack-h-wang added the platform Platform Team label Nov 15, 2024
@jack-h-wang jack-h-wang force-pushed the platform/jwang/orm-oml-java-classes branch from 559f30d to b373e92 Compare November 21, 2024 22:19
@jack-h-wang jack-h-wang marked this pull request as ready for review November 21, 2024 22:30
@jack-h-wang jack-h-wang requested a review from a team as a code owner November 21, 2024 22:30
@jack-h-wang
Copy link
Collaborator Author

Note the end2end_up test data needs to be updated to allow the test to pass in this branch, but I'm electing to wait until this is merged into OML-Updates-Base so that we can do all needed test updates in the PR to merge into main.

@JFisk42 JFisk42 self-assigned this Nov 21, 2024
Copy link
Collaborator

@JFisk42 JFisk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all of the /group/ changes, will review /segment/ changes in the morning. Just a couple small additions and two questions.

@JFisk42
Copy link
Collaborator

JFisk42 commented Nov 22, 2024

Note the end2end_up test data needs to be updated to allow the test to pass in this branch, but I'm electing to wait until this is merged into OML-Updates-Base so that we can do all needed test updates in the PR to merge into main.

Makes sense. There will already me a "merge conflicts test updates" commit for the PR back to main so this will be easy to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants