generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engagement/jessica/15406 cli download report #15675
Merged
JessicaWNava
merged 41 commits into
master
from
engagement/jessica/15406-cli-download-report
Sep 6, 2024
Merged
Changes from 31 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
9dd54c3
Creating custom FHIR function that returns a random value for various…
JessicaWNava 2b58146
Removing logging
JessicaWNava 46bf5c4
Addressing PR feedbakc and doing some cleanup after further testing
JessicaWNava 8cd7f3a
Adding in any missing types that were required per https://hl7-defini…
JessicaWNava 94ca3dc
Starting work on using the fake values to remove PII froma bundle
JessicaWNava e07c4f7
PII removal commit 2
JessicaWNava a890872
pii removal number 3
JessicaWNava 7064ee6
Moving PII removal over to code
JessicaWNava 9c06530
Removing AOEs and updating condition filter to include RSV
JessicaWNava 1dad44f
Merging changes
JessicaWNava 51a3fd3
Changing to use the transform again instead of code for all but id
JessicaWNava d9a10fe
Merge branch 'master' of https://github.com/CDCgov/prime-reportstream
JessicaWNava cdf4f2d
Merging changes from master
JessicaWNava fc560af
Added ability to set properties with index
victor-chaparro 4c9916c
PII removal combo of transform and code
JessicaWNava 8abde73
create documentation for hl7-fhir transforms
GilmoreA6 5a6131b
Revert "create documentation for hl7-fhir transforms"
GilmoreA6 7bf0da2
Created a command that downloads files from a specified environment a…
JessicaWNava 824f95f
Removing scratch file
JessicaWNava 4b2cc1e
Merge branch 'engagement/jessica/15405-deidentification-enrichment' o…
JessicaWNava 6c332da
Tests added for PII removal
JessicaWNava 56a658e
Added a comment for each method. Removed unnecessary id PII replacements
JessicaWNava 8187239
Merging in changes from the parent branch
JessicaWNava 2f4a638
Added unit tests for the download report cli command
JessicaWNava 2152c10
Merge branch 'master' of https://github.com/CDCgov/prime-reportstream
JessicaWNava 3250078
Removing unnecessary file:
JessicaWNava 9d35208
Updated the downlaod report to use Database Access instead of Workflo…
JessicaWNava f72074c
Merge branch 'master' of https://github.com/CDCgov/prime-reportstream
JessicaWNava 2278f87
Merging changes from master
JessicaWNava 561d63d
Moving download report over from being A CLI command to being an API
JessicaWNava b0656ac
Finished updating the tests
JessicaWNava 5f0d760
Changing how ReportFunction is initialized in the tests
JessicaWNava 46fbf8f
Updated how we do security for the endpoint and fixed a test
JessicaWNava 3d414bb
Fixing tests
JessicaWNava 994b97f
Fixing remove pii address
JessicaWNava f515b1b
Fixing a FHIR path
JessicaWNava e6cebab
Merge branch 'master' of https://github.com/CDCgov/prime-reportstream
JessicaWNava aee1237
Merge branch 'master' of https://github.com/CDCgov/prime-reportstream
JessicaWNava 0f782ec
Merging changes from master
JessicaWNava 9b664ae
Fixing function name of an API call accidentally duplicated
JessicaWNava a97f505
Merge branch 'master' into engagement/jessica/15406-cli-download-report
JessicaWNava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use an azure function key to call this API, since we will have to manually call this API every time we need a report and we won't be using the front end to call this API. It will make it easier to use and we wouldn't have to get a bearer token every time we wanted to use it.
There's an example inside
ReportFunction.kt
in line 70. You'd just have to set to authLevel toauthLevel = AuthorizationLevel.FUNCTION
and once it's in staging and prod we can generate a random key for it.If we do it that way we can remove the authentication logic and just rely on azure's authorization.