Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fax to contact points #2863

Draft
wants to merge 4 commits into
base: mcm/move-custom-fhir
Choose a base branch
from

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Nov 5, 2024

PULL REQUEST

Summary

Make sure the fax number is converted along with other telecom info. Depends on skylight-hq/FHIR-Converter#4

  • add to snapshot test for converter service
  • expect fax system usage in formatContactPoint
  • add unit test

Related Issue

Fixes #2695

Additional Information

Before:
image

With this change:
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@mcmcgrath13 mcmcgrath13 changed the title test: make sure fax gets converted Add fax to contact points Nov 5, 2024
@@ -1,7 +1,7 @@
FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build

# Download FHIR-Converter
RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/customize --single-branch /build/FHIR-Converter
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Don't merge until this points to a released version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant