Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECR Library sorting #2812

Merged
merged 29 commits into from
Nov 5, 2024
Merged

Add ECR Library sorting #2812

merged 29 commits into from
Nov 5, 2024

Conversation

lina-roth
Copy link
Collaborator

@lina-roth lina-roth commented Oct 24, 2024

PULL REQUEST

Screen Shot 2024-11-04 at 9 21 29 PM

Summary

  • Adding sorting to ECR Library

Related Issue

Fixes #2233

Acceptance Criteria

  • Sorting is available for 3 columns in the eCR Library Table:
    Patient Name
    Received Date
    Encounter Date
  • Sorting styling and functionality matches what's outlined in [USWDS table component guidance
  • The default sort is that the table is sorted by Received Date, with the most recent eCRs at the top. The arrow next to Received Date should be pointing up by default always to indicate this sort, but the column should not be highlighted blue until somebody clicks the arrow again
  • When any sort is applied, a Refresh button appears to the right of the filters, like in the screenshot below. Clicking the button resets any user defined sorting and filters:
  • If there is significant loading time, show shimmer loading effect to let the user know it's processing the request (this can be broken into another ticket if it's too much work for this ticket)
  • When the user refreshes the browser, sorting is NOT refreshed

Note: some of this styling and less functional changes will be completed in #2860

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@lina-roth lina-roth marked this pull request as draft October 24, 2024 00:45
@lina-roth lina-roth marked this pull request as ready for review November 5, 2024 00:26
@lina-roth lina-roth changed the title init Add ECR Library sorting Nov 5, 2024
@lina-roth lina-roth added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit b8f5d2a Nov 5, 2024
11 checks passed
@lina-roth lina-roth deleted the lr/sort-library branch November 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SORT: Add sorting for patient name & dates | eCR Library table
2 participants