Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy frontend as a docker image #37

Merged
merged 48 commits into from
Dec 11, 2023
Merged

deploy frontend as a docker image #37

merged 48 commits into from
Dec 11, 2023

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 5, 2023 •
edited
Loading

PULL REQUEST

Summary

  • Create a dockerfile and use it to build an image for the frontend.

Related Issue

Fixes #

Additional Information

  • Dockerfile came from the example from next.js
  • Each environment will need to provide a AZURE_WEBAPP_PUBLISH_PROFILE secret. This can be found in the app service
    image

BobanL added 30 commits December 1, 2023 11:10
@BobanL
add terraform changes
d5053a5
@BobanL
specify app location
1015014
@BobanL
add prebuild command
aaa877e
@BobanL
skip app build
2a8c15e
@BobanL
add prebuild command to see if it works
00c67d1
@BobanL
add appsvc file
6d0a1a0
@BobanL
add workflow to deploy on this branch
b3f6099
@BobanL
add ls command
3bd59b2
@BobanL
rename cd to front-end
8f20f14
@BobanL
fix build issues temp
46f3c75
@BobanL
update script to only zip .next folder
0a0aaf0
@BobanL
add command to start up app
66d24c9
@BobanL
add terraform deployment to auto-deploy
c7bb6b5
@BobanL
move out deployTerraform into own job
b3db64f
@BobanL
add branch name
b15c9cf
@BobanL
put build in deployment.yaml
b0a40b7
@BobanL
move needs terraform to deploy
941d78d
@BobanL
fix typo in terraform
8d9995a
@BobanL
set to dev2
d016db1
@BobanL
set environment name properly
4902f95
@BobanL
make it only use dev2
a53114f
@BobanL
update terraform job name to include env variable
78ed7c2
@BobanL
add proper curly brace around name
8c54a89
@BobanL
remove env name in terraform job
73b9e9e
@BobanL
add test echo statement
77c2eb4
@BobanL
add quotes around branch name
09c4a15
@BobanL
remove set env job
e67e9e1
@BobanL
fix the start up command for the app service
a903e76
@BobanL
include all files in artifact
a7867b1
@BobanL
revert next.config.js
035411b
@BobanL BobanL changed the title Boban/deploy frontend deploy frontend as a docker image Dec 5, 2023
KennethSkylight
KennethSkylight reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@KennethSkylight KennethSkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

front-end/next.config.js Show resolved Hide resolved
KennethSkylight
KennethSkylight approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@KennethSkylight KennethSkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nickbristow
nickbristow approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@nickbristow nickbristow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KennethSkylight KennethSkylight merged commit a00aa77 into main Dec 11, 2023
7 of 10 checks passed
@KennethSkylight KennethSkylight deleted the boban/deploy-frontend branch December 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KennethSkylight KennethSkylight KennethSkylight approved these changes

@nickbristow nickbristow nickbristow approved these changes

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell

@emmastephenson emmastephenson Awaiting requested review from emmastephenson

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobanL @nickbristow @KennethSkylight