Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Error Handling #32

Merged
merged 10 commits into from
Nov 30, 2023
Merged

File Error Handling #32

merged 10 commits into from
Nov 30, 2023

Conversation

KennethSkylight
Copy link
Collaborator

PULL REQUEST

Summary

Adds error handling for both .zip and too large file size. It doesn't use the default React USWDS because it was too difficult. Error handling is all custom. Includes the tests for the functionality as well

Large file error

image

Wrong file type error

image

Related Issue

Fixes #876 and #875

@KennethSkylight KennethSkylight changed the title File error handling File Error Handling Nov 28, 2023
@sarahtress
Copy link
Collaborator

@KennethSkylight thanks for the screenshots!

few things:

  • the alignment on the left is not all aligned, all elements should have the same vertical alignment on the left. not sure how else to explain that better in writing (perhaps the file input box and buttons below should be shifted to the right to align with the text above it? does that make sense?)
  • also this can be addressed in a separate ticket since it's not specifically about the error design, but I just noticed in the blue box, the "this tool is..." text oddly cuts off to be on a second line seemingly for no reason. is it possible to get "site." to be in the first line so it's not unnecessarily 2 lines of text? if that's too tricky here I'll document as a future improvement

@KennethSkylight
Copy link
Collaborator Author

KennethSkylight commented Nov 30, 2023

@sarahtress Here's the new alignment

image

@sarahtress
Copy link
Collaborator

@KennethSkylight looks good for the alignment! any thoughts on being able to fix in the blue box "site." being on the next line? I can add that to a future improvement if it's too much for this ticket, just lmk!

@KennethSkylight
Copy link
Collaborator Author

@sarahtress oops my bad didn't commit that change.

image

@KennethSkylight KennethSkylight merged commit 76ef3e4 into main Nov 30, 2023
2 checks passed
@KennethSkylight KennethSkylight deleted the file-error-handling branch November 30, 2023 18:41
@sarahtress
Copy link
Collaborator

@KennethSkylight looks great! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants