generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Error Handling #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennethSkylight
requested review from
nickbristow,
gordonfarrell and
sarahtress
November 28, 2023 20:59
nickbristow
approved these changes
Nov 28, 2023
@KennethSkylight thanks for the screenshots! few things:
|
@sarahtress Here's the new alignment |
@KennethSkylight looks good for the alignment! any thoughts on being able to fix in the blue box "site." being on the next line? I can add that to a future improvement if it's too much for this ticket, just lmk! |
@sarahtress oops my bad didn't commit that change. |
@KennethSkylight looks great! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Adds error handling for both .zip and too large file size. It doesn't use the default React USWDS because it was too difficult. Error handling is all custom. Includes the tests for the functionality as well
Large file error
Wrong file type error
Related Issue
Fixes #876 and #875