ECR Viwer Demo Site

[JNygaard-Skylight]

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #846

Additional Information

[KennethSkylight]

LGTM, except for the tests

[sarahtress]

hey @JNygaard-Skylight is the screenshot in the description ready for design review? let me know if it is and I can send over comments - thanks!

[sarahtress]

@JNygaard-Skylight thanks for adding the screenshot - a few comments:

• The positioning and spacing for the text and buttons should match the previous pages. I'm not sure exactly what it has been set to in the code but the few things that look off are: the width of the content is too large, the text isn't centered on the page, the table isn't left justified with the rest of the content, the font for "you can view..." looks different from the rest of the fonts
• What shade of gray are you using for the top of the table? is it the USWDS default? it looks a bit dark, but maybe my designs aren't properly aligned with the USWDS default setttings
• the table should include all eCR fields that LAC had requested. is there a reason there are only 5 in this view?
• is our default for names all caps? I'm just surprised that's our default standardization setting, but it's not really in the scope of this ticket, as long as the data is being pulled from the result of the pipeline not the source data. if a bunch of the data fields are looking sort of wonky/not user friendly, @emmastephenson we might need to consider having another ticket to modify the names of fields and their output settings to be more user friendly (for example, Patient Id should be Patient ID, Birth Date should be Date of Birth or DOB) I just think it makes the design look less professional when the data comes out like that
• this one is my fault with the design, but if the table ends up being super long, we may need to put the buttons above the table, but I'll wait until I see what it looks like with a larger table first
• there should not be a period at the end of (JSON file)

let me know if you have any questions on the above!