Add orchestration resources to Terraform #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 821/add-orchestration
emmastephenson
commented
Nov 9, 2023
| ingestion = "ingestion-chart", | ||
| ingress = "ingress-chart", | ||
| message-parser = "message-parser-chart", | ||
| orchestration = "orchestration", |
There was a problem hiding this comment.
note: orchestration-chart didn't work because the name kept cutting off right at orchestration- and TF would complain that it was an invalid name. The solution here was to rename the chart at the Helm level, and create this mapping to track microservice name <=> chart name.
emmastephenson
commented
Nov 9, 2023
| set { | ||
| name = "image.tag" | ||
| value = "latest" | ||
| value = "v1.1.1" |
There was a problem hiding this comment.
The latest version of each Docker image wasn't being picked up by Terraform, so each deployment was at a wildly different image version (whatever had been latest when the service was first deployed). The workflow to make changes is therefore:
- Make your changes to the Docker container
- Publish changes as new release version
- Update this image tag
- Push these changes and re-deploy to desired env
emmastephenson
requested review from
KennethSkylight,
gordonfarrell and
nickbristow
nickbristow
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Adds the orchestration service to our TF-managed Helm deployments. This means the orchestration service is now up and running live! You can see it on
dev.Related Issue
Fixes #821
Additional Information
There are a number of related changes in
phdi-charts, but those have all been merged.Some followup actions - the newly named orchestration Service resource didn't redeploy when I pushed the new chart version, I had to destroy/recreate manually. Could be another argument for something like ArgoCD.