Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function To Cast InferenceData Into
tidy_draws
Format #36base: main
Are you sure you want to change the base?
Function To Cast InferenceData Into
tidy_draws
Format #36Changes from all commits
3865001
763355e
44e7fe2
31c7b72
9a87902
c632ae8
123ad51
a3c2d17
f44a6ee
cb883e3
df922d4
21968be
7dcd7d3
718ba85
7394d4d
4a77d50
4c18634
9be91b4
0884c3d
0dd9616
2a0f2b9
c746e3b
e4e8e0f
c5ed832
e9e2aab
9a27187
cc20975
4a8a0ae
0c4301a
814f68c
beba8f3
b12ffc2
d85f49c
85c0dbf
786d2e4
4c4e6dd
e949796
ab0beb6
27e7ada
b06f6e6
42acd05
2ed4c29
0ad7c24
9452acd
325aac4
462d57b
dae049f
5e4cd63
5c28831
d246a44
496c65c
2c34af7
dba6e7a
e1cdbb9
9884aa9
90f5484
683a7bf
3547ab6
2999ec3
04d6a50
cdbe464
987c273
8361c36
41a8136
bb55bf4
1cdef9d
519c048
1019ac0
92c34bd
b3f6367
84bb99e
1a94da4
7a737f6
740f9c8
b3544e5
3c9609c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to drop
"draws_per_chain"
, but also it's not a given that all chains will have the same number of draws. Instead, more robust do compute this as.iteration + <n_draws_in_all_previous_chains>
. Many ways to do that in polars.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running
np.random.seed
changes global state. Better practice to do something like this https://builtin.com/data-science/numpy-random-seedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run the test on the provided
inference_data_1.nc
? Or are you planning to remove it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am on the fence about removing it. Seems good to have a canonical
pyrenew-hew
.nc
file on hand esp. given thatforecasttools-py
does / will even more so interface abundantly withpyrenew
models. On the other hand, having adequate and generalidata
/xarray
representations seems good for testing too. I do not know if the latter must exist at the cost of the former. I lean towards having both, with the.nc
file perhaps being used in notebooks and the "fake"idata
s being used for testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to check that individual values are as expected, not just that the draws are unique and one for each row.