-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QoL updates ✅ #24
QoL updates ✅ #24
Conversation
f46d10d
to
a2f5711
Compare
1a8f2f9
to
4749dd5
Compare
4749dd5
to
0798ca3
Compare
16cbd35
to
f1d3625
Compare
65b96f5
to
be9551c
Compare
cadbd71
to
80ae92e
Compare
80ae92e
to
e0393f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. The more documentation we can provide to walk the customer through the options this repo provides, the easier it'll be for them to understand and use it on their own.
I remember you created a gif video you showed us during your module demo, we can add artifacts like that to a docs folder in the repo. I see potential for a follow-up PR that focuses on common FAQs or visuals like a network diagram that depicts the default state.
3b7b46c
to
6f6b3ed
Compare
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
environment
to useworkspace
instead to keep things consistent with jargon used by terraformtfstate
related terraform into a module to better encapsulate those resourcesinternal
variable to better setup resources in private subnets and prevent the creation of certain VPC resourcesservice_data
to includemin_capacity
andmax_capacity
so that we can handle autoscaling