Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL updates ✅ #24

Merged
merged 9 commits into from
Nov 4, 2024
Merged

QoL updates ✅ #24

merged 9 commits into from
Nov 4, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Oct 3, 2024

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

@alismx alismx force-pushed the alis/private_subnet_updates branch 2 times, most recently from f46d10d to a2f5711 Compare October 9, 2024 15:39
@alismx alismx force-pushed the alis/private_subnet_updates branch 3 times, most recently from 1a8f2f9 to 4749dd5 Compare October 15, 2024 19:01
@alismx alismx force-pushed the alis/private_subnet_updates branch from 4749dd5 to 0798ca3 Compare October 15, 2024 19:03
@alismx alismx force-pushed the alis/private_subnet_updates branch 5 times, most recently from 16cbd35 to f1d3625 Compare October 15, 2024 22:37
@alismx alismx force-pushed the alis/private_subnet_updates branch 6 times, most recently from 65b96f5 to be9551c Compare October 16, 2024 21:16
@alismx alismx force-pushed the alis/private_subnet_updates branch 2 times, most recently from cadbd71 to 80ae92e Compare October 17, 2024 18:22
@alismx alismx force-pushed the alis/private_subnet_updates branch from 80ae92e to e0393f9 Compare October 17, 2024 18:58
@alismx alismx changed the title update private subnets so they can pull from ecr QoL updates ✅ Oct 18, 2024
@alismx alismx marked this pull request as ready for review October 18, 2024 18:28
.github/workflows/deployment.yaml Outdated Show resolved Hide resolved
.github/workflows/deployment.yaml Outdated Show resolved Hide resolved
.github/workflows/deployment.yaml Outdated Show resolved Hide resolved
terraform/implementation/ecs/_variable.tf Outdated Show resolved Hide resolved
terraform/modules/ecs/_variable.tf Show resolved Hide resolved
terraform/modules/ecs/alb.tf Outdated Show resolved Hide resolved
terraform/modules/ecs/ecs.tf Show resolved Hide resolved
terraform/modules/oidc/_variable.tf Outdated Show resolved Hide resolved
terraform/modules/tfstate/_variable.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The more documentation we can provide to walk the customer through the options this repo provides, the easier it'll be for them to understand and use it on their own.

I remember you created a gif video you showed us during your module demo, we can add artifacts like that to a docs folder in the repo. I see potential for a follow-up PR that focuses on common FAQs or visuals like a network diagram that depicts the default state.

@alismx alismx force-pushed the alis/private_subnet_updates branch from 3b7b46c to 6f6b3ed Compare November 4, 2024 20:16
@alismx alismx merged commit b57dae7 into main Nov 4, 2024
1 check passed
@alismx alismx deleted the alis/private_subnet_updates branch November 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants