Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image management update 🐦 #22

Merged
merged 2 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions terraform/implementation/ecs/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ echo "Bucket: $BUCKET"
echo "DynamoDB Table: $DYNAMODB_TABLE"
echo "Region: $REGION"
cat "$ENVIRONMENT.tfvars"
echo ""

terraform init \
-var-file="$ENVIRONMENT.tfvars" \
Expand Down
4 changes: 3 additions & 1 deletion terraform/implementation/ecs/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ module "ecs" {
project = var.project
tags = local.tags

# If intent is to use the non-integrated viewer, set this to true (default is false)
# If intent is to pull from the phdi GHCR, set disable_ecr to true (default is false)
# disable_ecr = true
# If intent is to use the non-integrated viewer, set non_integrated_viewer to true (default is false)
# non_integrated_viewer = "true"
}
14 changes: 7 additions & 7 deletions terraform/modules/ecs/_local.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-ecr-viewer",
app_image = var.disable_ecr == false ? "${terraform.workspace}-ecr-viewer" : "ecr-viewer",
app_version = var.phdi_version,
container_port = 3000,
host_port = 3000,
Expand Down Expand Up @@ -61,7 +61,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-fhir-converter",
app_image = var.disable_ecr == false ? "${terraform.workspace}-fhir-converter" : "fhir-converter",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand All @@ -74,7 +74,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-ingestion",
app_image = var.disable_ecr == false ? "${terraform.workspace}-ingestion" : "ingestion",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand All @@ -87,7 +87,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-validation",
app_image = var.disable_ecr == false ? "${terraform.workspace}-validation" : "validation",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand All @@ -100,7 +100,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-trigger-code-reference",
app_image = var.disable_ecr == false ? "${terraform.workspace}-trigger-code-reference" : "trigger-code-reference",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand All @@ -113,7 +113,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-message-parser",
app_image = var.disable_ecr == false ? "${terraform.workspace}-message-parser" : "message-parser",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand All @@ -126,7 +126,7 @@ locals {
fargate_cpu = 1024,
fargate_memory = 2048,
app_count = 1
app_image = "${terraform.workspace}-orchestration",
app_image = var.disable_ecr == false ? "${terraform.workspace}-orchestration" : "orchestration",
app_version = var.phdi_version,
container_port = 8080,
host_port = 8080,
Expand Down
2 changes: 1 addition & 1 deletion terraform/modules/ecs/ecs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ resource "aws_ecs_task_definition" "this" {
container_definitions = jsonencode([
{
name = each.key,
image = "${each.value.registry_url}/${each.value.app_image}:${each.value.app_version}",
image = var.disable_ecr == false ? dockerless_remote_image.dibbs[each.key].target : "${each.value.registry_url}/${each.value.app_image}:${each.value.app_version}",
networkMode = "awsvpc",
logConfiguration = {
logDriver = "awslogs",
Expand Down
46 changes: 3 additions & 43 deletions terraform/modules/ecs/enable_ecr.tf
Original file line number Diff line number Diff line change
@@ -1,47 +1,7 @@
data "docker_registry_image" "dibbs" {
resource "dockerless_remote_image" "dibbs" {
for_each = var.disable_ecr == false ? local.service_data : {}
name = "ghcr.io/cdcgov/phdi/${each.key}:${each.value.app_version}"
}

resource "docker_image" "dibbs" {
for_each = var.disable_ecr == false ? local.service_data : {}
name = data.docker_registry_image.dibbs[each.key].name
keep_locally = true
pull_triggers = [data.docker_registry_image.dibbs[each.key].sha256_digest, plantimestamp()]
force_remove = true
}

resource "docker_tag" "this" {
for_each = var.disable_ecr == false ? local.service_data : {}
source_image = docker_image.dibbs[each.key].name
target_image = "${each.value.registry_url}/${each.value.app_image}:${each.value.app_version}"
lifecycle {
replace_triggered_by = [
null_resource.docker_tag
]
}
}

resource "docker_registry_image" "this" {
for_each = var.disable_ecr == false ? local.service_data : {}
name = "${each.value.registry_url}/${each.value.app_image}:${each.value.app_version}"
depends_on = [
docker_image.dibbs,
docker_tag.this,
aws_ecr_repository.this
]
keep_remotely = true

triggers = {
sha256_digest = data.docker_registry_image.dibbs[each.key].sha256_digest
}
}

resource "null_resource" "docker_tag" {
for_each = docker_image.dibbs
triggers = {
docker_image = each.value.id
}
source = "ghcr.io/cdcgov/phdi/${each.key}:${each.value.app_version}"
target = "${each.value.registry_url}/${each.value.app_image}:${each.value.app_version}"
}

data "aws_ecr_authorization_token" "this" {}
Expand Down
30 changes: 9 additions & 21 deletions terraform/modules/ecs/provider.tf
Original file line number Diff line number Diff line change
@@ -1,29 +1,17 @@
terraform {
required_providers {
docker = {
source = "kreuzwerker/docker"
version = "3.0.2"
dockerless = {
source = "nullstone-io/dockerless"
version = "0.1.1"
}
}
}

provider "docker" {
# Note: Terraform will automatically communicate with the local
# Docker daemon using the default Unix socket
host = "unix:///var/run/docker.sock"
registry_auth {
auth_disabled = var.disable_ecr
address = local.registry_auth
username = local.registry_username
password = local.registry_password

config_file_content = jsonencode({
"auths" = {
"${data.aws_caller_identity.current.account_id}.dkr.ecr.${var.region}.amazonaws.com" = {},
}
"credHelpers" = {
"${data.aws_caller_identity.current.account_id}.dkr.ecr.${var.region}.amazonaws.com" = "ecr-login",
}
})
provider "dockerless" {
registry_auth = {
"${data.aws_caller_identity.current.account_id}.dkr.ecr.${var.region}.amazonaws.com" = {
username = local.registry_username
password = local.registry_password
}
}
}