Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker builds with libodbc #179

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Jan 23, 2025

Description

Corrects the syntax of the if block in the Dockerfile to ensure proper evaluation for installing msodbcsql18 and unixodbc-dev. This fix resolves an issue where the Record Linker image fails to start when configured with a sqlserver DB_URI.

Additional Notes

This is a significant issue for users who want to: a) use our published Docker images on ghcr.io and b) connect to a sqlserver database. The if block on line 30 of the Dockerfile has syntax that works with /bin/bash but not with /bin/sh. As a result, the step was always skipped during the image build process.

This update introduces a database matrix to our smoke tests, enabling the Docker image to be tested against all four supported databases, not just PostgreSQL.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the bug Something isn't working label Jan 23, 2025
@ericbuckley ericbuckley self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (663222f) to head (23eacc1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          31       31           
  Lines        1521     1521           
=======================================
  Hits         1484     1484           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley changed the title run smoke tests against all the DBs fix: docker builds with libodbc Jan 23, 2025
@ericbuckley ericbuckley requested a review from bamader January 23, 2025 11:54
@ericbuckley ericbuckley marked this pull request as ready for review January 23, 2025 11:54
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@ericbuckley ericbuckley merged commit 99dc42d into main Jan 23, 2025
16 checks passed
@ericbuckley ericbuckley deleted the fix/build-docker-with-libodbc branch January 23, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants