Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects the syntax of the if block in the Dockerfile to ensure proper evaluation for installing msodbcsql18 and unixodbc-dev. This fix resolves an issue where the Record Linker image fails to start when configured with a sqlserver DB_URI.
Additional Notes
This is a significant issue for users who want to: a) use our published Docker images on ghcr.io and b) connect to a sqlserver database. The if block on line 30 of the Dockerfile has syntax that works with /bin/bash but not with /bin/sh. As a result, the step was always skipped during the image build process.
This update introduces a database matrix to our smoke tests, enabling the Docker image to be tested against all four supported databases, not just PostgreSQL.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: