Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed API #124

Merged
merged 34 commits into from
Nov 14, 2024
Merged

seed API #124

merged 34 commits into from
Nov 14, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Nov 8, 2024

Description

Adding a new API endpoint, /seed, to control initializing the MPI tables with data. POST /seed is used to insert person/patient clusters into the MPI and DELETE /seed is used to reset the MPI.

Related Issues

closes #122

Additional Notes

  • Updating the unit test CI job to combine all the coverage reports from the matrix of tests before uploading to codecov. This changeset adds some features not compatible with MySQL, thus some test cases are skipped depending on the database dialect.
  • adding mpi_service.bulk_insert_patients, essentially the same functionality of insert_patient, but is faster when attempting to insert more than 1 patient.
  • MySQL doesn't support all the bulk insert features, so it will be slower than the other dialects when using /seed

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (6340323) to head (8d3ca11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   95.28%   95.56%   +0.28%     
==========================================
  Files          29       31       +2     
  Lines        1293     1375      +82     
==========================================
+ Hits         1232     1314      +82     
  Misses         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review November 9, 2024 05:12
@ericbuckley ericbuckley merged commit 2e2af2d into main Nov 14, 2024
12 checks passed
@ericbuckley ericbuckley deleted the feature/122-seed-api branch November 14, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/seed API endpoint
2 participants