Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers License Feature #113

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

cbrinson-rise8
Copy link
Collaborator

@cbrinson-rise8 cbrinson-rise8 commented Oct 31, 2024

Description

Add a new Feature to run comparisons on driver's license numbers.

Related Issues

closes #95

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (fc0d164) to head (e4a8c7b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   95.11%   95.17%   +0.05%     
==========================================
  Files          26       26              
  Lines        1269     1284      +15     
==========================================
+ Hits         1207     1222      +15     
  Misses         62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbrinson-rise8 cbrinson-rise8 marked this pull request as ready for review October 31, 2024 21:21
@cbrinson-rise8 cbrinson-rise8 force-pushed the feat/add-drivers-license-feature branch from 660152d to f55fc4a Compare November 1, 2024 15:59
@cbrinson-rise8 cbrinson-rise8 force-pushed the feat/add-drivers-license-feature branch from f55fc4a to e4a8c7b Compare November 1, 2024 16:00
Copy link
Collaborator

@ericbuckley ericbuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @cbrinson-rise8 looks great.

@cbrinson-rise8 cbrinson-rise8 merged commit e87247a into main Nov 1, 2024
10 checks passed
@cbrinson-rise8 cbrinson-rise8 deleted the feat/add-drivers-license-feature branch November 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature to compare Driver's License number
2 participants