-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractDynodeRunner
code reorg and naming revamp
#316
Conversation
…DCgov/DynODE into generate-timeseries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked through vis_utils and part of save_inference_timeseries, will have to get back to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked about renaming functions in call, implement and good to gooo!!!
…model_compnent_timeseries now private
this PR does the following:
save_inference_timeseries
now takes particle tuples as a list instead of randomly selecting, allowing for better user control over its behavior. The method will also return the saved dataframe instead of a str of where it was saved to. If user passesNone
tosave_filename
the csv will not be saved at all, in case that is required.AbstractDynodeRunner
out intoutils
so they may be more easily referenced by other code, as well as declutter the class itself.timelines
totimeseries
when referring to the saving of metrics like vaccination or infection counts of a simulation.azure_visualizer_timelines.csv
auto-generated file tosimulation_timeseries.csv
so it is easier to understand what it contains. Also the csv is used in much more than just the shiny app visualizers...CLOSES #311
while this PR closes #311 some lasting software design decisions have made the request for parallelized loading of posterior particles not possible without substantial changes. I will create an issue #315 to track that