Dev #315
Merged
Dev #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @Pavel401 I remove the flushBar from earlier since it caused and issue with adding the task, it didn't close it if the flush bar was still on screen for its 2 seconds, and I just made do with the snackBar instead. |
|
Hi @Sabra-xD, thank you for submitting the PR. By the way, could you replace the dialog with a snack bar on the task server page? In most places, we use Snackbar throughout the app, so it would be great if the new one matched. Also, please make sure that the snack bar matches the theme of the app, both in dark and light mode. Thank you! |
|
@Pavel401 Done. |
|
Hey @Pavel401 I have added the solution for the most recent issue to the PR. |
Pavel401
approved these changes
Feb 25, 2024
This was referenced Feb 25, 2024
|
From next time please send multiple PRs for each issue. @Sabra-xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A notifier needed to be displayed for the user in a snackBar.
Wrapped the AlertDialog of add_Task with a Scaffold, so the snackBar's ScaffoldMessanger can locate it and displayed the message.
Also, highlighted the due time to be in red when the time selected is in the past.
AlertDialog is being displayed if the user haven't set up a TaskServer.
Fixes #(314 & 308 & 316)
Screenshots
Checklist