Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting alert time clock in the past. #312

Closed
1 task done
Sabra-xD opened this issue Feb 22, 2024 · 5 comments
Closed
1 task done

Setting alert time clock in the past. #312

Sabra-xD opened this issue Feb 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Sabra-xD
Copy link
Contributor

Sabra-xD commented Feb 22, 2024

Describe your issue

Right now when the user sets the time to be alerted for their task through the clock. You can set the time to be in the past, as in if it is currently 2PM. The alert time can be set to 1PM.

Steps to reproduce

None

What was the expected result?

To only be able to set the alert time in the future.

Put here any screenshots or videos (optional)

Record_2024-02-22-03-12-51.mp4

How can we contact you (optional)

None

Would you like to work on this issue?

Yes

By submitting this issue, I have confirmed that:

  • I have starred the repo ⭐ and watched 👀 it on GitHub and followed the contribution guidelines.
@Sabra-xD Sabra-xD added the bug Something isn't working label Feb 22, 2024
@cfsmp3
Copy link
Collaborator

cfsmp3 commented Feb 22, 2024

I'm not 100% sure this is a bug; obviously you won't be able to do something by the due date if it's in the past, but at the same time I might have forgotten to add a task in the past and I want to add it now while maintaining the original due date, so I know how late I am.

I think I'd leave it at is. Or maybe allow it but display a dialog about it in case the user is just making a mistake.

@Sabra-xD
Copy link
Contributor Author

Alright. Anyway, the due time is set to Due: - in this case which needs to be adjusted.
And I think the design for over due tasks should be unique to catch the user's attention and sets it out from the current scheduled tasks.

@Pavel401
Copy link
Member

I think we should display a snack bar message if the user sets a past time instead of considering it as a bug, as mentioned by @cfsmp3.

@Sabra-xD
Copy link
Contributor Author

I found a snackBar was already being used but it was not in-foucs since it used ScaffoldMessanger and we were working on the AlertDialog, so it displayed the snackBar message in the Scaffold.
So, I deleted it and added FlushBar to be able to display the message in the current context.

Also I high lighted the time, if it was now or in the past, set it to red just to get user's attention.
You can check out the PR. #314

@Pavel401
Copy link
Member

Fixed in #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants