Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the need of mandatory destination config #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eliminate the need of mandatory destination config #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,4 @@ Clones the repo, builds the site, and commits it back to the gh-pages branch of
* This uses the v2 of the Actions beta—note the Yaml based workflow syntax—you must have access to the beta release of actions.
* **`GITHUB_TOKEN`, privileges are still being sorted out by the Actions/GH-Pages team. Changes pushed to your GH-pages branch will only be picked up by the Github Pages server if your workflow is in a private repository.**
* Needs a .gemfile
* `destination:` should be set to `./build` in your _config.yml file—as God demands.
* Be sure that any custom gems needed are included in your Gemfile.
* Be sure that any custom gems needed are included in your Gemfile.
3 changes: 1 addition & 2 deletions build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,4 @@ Clones the repo and builds the site—that's it.
## Caveats

* Needs a .gemfile
* `destination:` should be set to `./build` in your _config.yml file—as God demands.
* Be sure that any custom gems needed are included in your Gemfile.
* Be sure that any custom gems needed are included in your Gemfile.
2 changes: 1 addition & 1 deletion build/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ echo '👍 ENTRYPOINT HAS STARTED—INSTALLING THE GEM BUNDLE'
bundle install > /dev/null 2>&1
bundle list | grep "jekyll ("
echo '👍 BUNDLE INSTALLED—BUILDING THE SITE'
bundle exec jekyll build
bundle exec jekyll build -d ./build
echo '👍 THE SITE IS BUILT—GREAT SUCCESS'

1 change: 0 additions & 1 deletion deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,4 @@ Grabs the site files in `build` and commits them to the gh-pages branch of the s

## Caveats

* `destination:` should have beeen set to `./build` in your _config.yml file—as God demands.
* Remember when adding this action to a workflow that will also use a build action, you need to define that action in the `needs` paramater.
2 changes: 1 addition & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ echo '👍 ENTRYPOINT HAS STARTED—INSTALLING THE GEM BUNDLE'
bundle install
bundle list | grep "jekyll ("
echo '👍 BUNDLE INSTALLED—BUILDING THE SITE'
bundle exec jekyll build
bundle exec jekyll build -d ./build
echo '👍 THE SITE IS BUILT—PUSHING IT BACK TO GITHUB-PAGES'
cd build
remote_repo="https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git" && \
Expand Down