Eliminate the need of mandatory destination config #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing users to change their config files to get it working with this action is not a good out-of-the-box experience and might come in the way to their other workflow steps. It would have been better if this action would have followed the default Jekyll behavior and used
_sitefolder instead while giving an option for users to let the action know if they have customized the destination folder. However, this action seems to be forcing the decision the other way by asking users to change their config according to the hard coded setup of this action.In this PR I have taken an intermediary approach which does not give users the option to tell their configured destination folder, but does not ask them to change that either. I have not tested these changes yet, but I am assuming that Jekyll would give command line arguments precedence over corresponding config file entry, if present.