Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a solgov variant of the squad vendor #2669

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Pockets-byte
Copy link
Contributor

@Pockets-byte Pockets-byte commented May 31, 2024

it gives out laser pistols not handguns.

Why It's Good For The Game

pew

this also allows for not just weapon differences, but multiple squad vendors dispensing different sets of gear on the same map/server, as well as the ability to have varying loadouts, ghost role squad vendors, syndicate squad vendors, etc.

Testing Photographs and Procedure

Screenshots&Videos
out.3.mp4

Changelog

🆑
add: Added solgov variant of the squad vendor
/:cl:

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need to give squad vendors laser guns for Solgov, the glocks are already pretty good and you can grab guns from the armory too.

nsv13/code/modules/squads/squad_vendor.dm Outdated Show resolved Hide resolved
@Pockets-byte
Copy link
Contributor Author

Pockets-byte commented May 31, 2024

I don't think we really need to give squad vendors laser guns for Solgov, the glocks are already pretty good and you can grab guns from the armory too.

it's less about good, and more about thematics- I'd personally like to see fewer ballistics on solgov ships to make them feel more different- if we need a "less powerful" standard laser pistol to go into this, that's probably an easy shake
the laser pistol does just inherit everything from the normal laser gun right now

@Pockets-byte
Copy link
Contributor Author

if the standard variant of retro lasers are considered to be too strong, they can be exchanged for the old variant

@Pockets-byte Pockets-byte requested a review from a team as a code owner June 7, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants