Skip to content

Fixed address sanitizer flags when using clang on windows #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioRZMasson merged 3 commits into from
Mar 19, 2026
Merged

Fixed address sanitizer flags when using clang on windows #1632

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bcd8f6
Fixed adress sanitizer flags when using clang on windows
SergioRZMasson Mar 16, 2026
41bf04d
Updated JsRuntimeHost
SergioRZMasson Mar 17, 2026
4a79f09
merged master
SergioRZMasson Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ FetchContent_Declare(ios-cmake
EXCLUDE_FROM_ALL)
FetchContent_Declare(JsRuntimeHost
GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git
GIT_TAG a7bcbd4bcd0d92e2ef05a92daf490298fde74ead)
GIT_TAG 08b5ecc5c7d85e617bb44f9394b3517097dd7e3e)
FetchContent_Declare(libwebp
GIT_REPOSITORY https://github.com/webmproject/libwebp.git
GIT_TAG 57e324e2eb99be46df46d77b65705e34a7ae616c
Expand Down Expand Up @@ -147,7 +147,10 @@ if(ENABLE_SANITIZERS)
set(SANITIZERS "address,undefined")
# Check for Clang since vptr and fdsan are Clang-specific
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND SANITIZERS "vptr")
# vptr is not supported on Windows.
if(NOT WIN32)
list(APPEND SANITIZERS "vptr")
endif()
# FDSan only works on Android builds with Clang
if (ANDROID)
list(APPEND SANITIZERS "fdsan")
Expand Down
Loading