Fixed address sanitizer flags when using clang on windows#1632
Open
SergioRZMasson wants to merge 3 commits intoBabylonJS:masterfrom
Open
Fixed address sanitizer flags when using clang on windows#1632SergioRZMasson wants to merge 3 commits intoBabylonJS:masterfrom
SergioRZMasson wants to merge 3 commits intoBabylonJS:masterfrom
Conversation
bghgary
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the sanitizer configuration in the top-level CMake to avoid enabling Clang’s vptr sanitizer on Windows, preventing invalid -fsanitize= combinations when building with Clang on that platform.
Changes:
- Guard
vptrsanitizer inclusion behindNOT WIN32when using Clang. - Keep existing Clang-only sanitizer additions (e.g.,
fdsanon Android) unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed address sanitizer flags when using clang on windows.