Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update readme to pass static test #3832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update readme to pass static test #3832

wants to merge 2 commits into from
+9 −0

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Nov 22, 2024 •
edited
Loading

Description

Fixes #3829

Pipeline Reference

Pipeline
avm.res.compute.virtual-machine-scale-set

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@rahalan rahalan added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Resource Module 📦 This is a resource module labels Nov 22, 2024
@rahalan rahalan self-assigned this Nov 22, 2024
@rahalan rahalan requested review from a team as code owners November 22, 2024 14:50
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 22, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

eriqua
eriqua reviewed Nov 22, 2024
View reviewed changes
avm/res/compute/virtual-machine-scale-set/README.md
@@ -362,6 +362,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
enabled: true
}
extensionMonitoringAgentConfig: {
autoUpgradeMinorVersion: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the previously failed pipeline expected to release a new version? If so, please also update something minor in main.bicep (e.g., a parameter description) and compile the main.json so that the PR can qualify for publishing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriqua the version was already updated, but the readme not, so the new version was never published

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case it will continue to not be published, because this PR will not trigger the publishing step.

If we want to fix the missing publishing, we need the main.json to be updated. For that we need a small change in main.bicep and then compile the main.json

@rahalan rahalan enabled auto-merge (squash) November 22, 2024 15:07
@eriqua eriqua mentioned this pull request Nov 22, 2024
Merged
11 tasks
@FallenHoot
Copy link
Contributor

FallenHoot commented Nov 23, 2024 •
edited
Loading

I checked this as well:
avm.res.compute.virtual-machine-scale-set
I see no issue with the deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rahalan rahalan

Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.compute.virtual-machine-scale-set
3 participants
@rahalan @FallenHoot @eriqua