Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update bicep version -> new json #3834

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Nov 22, 2024

Description

Missed the extension json. This needed also a regeneration after the new Bicep version was released.

Pipeline Reference

Pipeline
avm.res.compute.virtual-machine

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@rahalan rahalan added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Resource Module 📦 This is a resource module labels Nov 22, 2024
@rahalan rahalan self-assigned this Nov 22, 2024
@rahalan rahalan requested review from a team as code owners November 22, 2024 15:57
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 22, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@rahalan rahalan marked this pull request as draft November 22, 2024 15:58
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Nov 22, 2024
@rahalan rahalan marked this pull request as ready for review November 22, 2024 16:08
Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.31.34.60546",
"templateHash": "1194243367873711347"
"version": "0.31.92.45157",
Copy link
Contributor

@eriqua eriqua Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only will not qualify for publishing. Mentioning in case the previous failure intended to release a new version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriqua can't follow. What is needed in your opinion? The whole update is only, because Bicep released a new version. Nothing changed in the module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no version to be released is stuck then it's fine, but it's important we're all aligned on how publishing works.

  • If main.json is updated then a new version is published.
  • If the pipeline fails, the version is not published until another PR is open, where the main.json is updated again.

So my comment here is, since avm/res/compute/virtual-machine/main.json is not updated in this PR, but it was in the previous one, which failed, the corresponding new version will not be published with this PR.

This is similar to the comment I added to #3832, but in that case is more relevant.

For this PR, if we want a new version to be published, we need a small update to avm/res/compute/virtual-machine/main.json as well. If that is not needed, then we're good to go and you can resolve this comment.

Copy link
Contributor

@AlexanderSehr AlexanderSehr Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - I prepared a beautiful comment to +1 on @eriqua's point and instead of clicking on 'comment', I accidently selected 'resolve conversation'. Shame on me.

Also a shame that my text is gone - so let me start over in a short version:

  • Your next action should be determined based on whether should should (have) lead to a new version being published or not
  • If the PR was just added to fix an issue with the template with new intention of publishing a new version, there was no added action needed.
  • If you actually wanted a new version (e.g., because previous changes were not published due to this template issue), then a dummy change (outside the module's metadata) would've been required. For example in the a module parameter's description.

@eriqua, I'm terribly sorry. @rahalan, please create or not create a new PR based on whether you wanted to have a new published version 😉

@rahalan rahalan enabled auto-merge (squash) November 22, 2024 16:12
@rahalan rahalan merged commit 7efbdbf into Azure:main Nov 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants