Skip to content

Conversation

@live1206
Copy link
Member

@live1206 live1206 commented Jun 19, 2025

This PR is to release a beta package of Azure.ResourceManager to apply with the code change from generator in Azure/autorest.csharp#5347

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Jun 19, 2025
@live1206 live1206 marked this pull request as ready for review June 19, 2025 11:53
Copilot AI review requested due to automatic review settings June 19, 2025 11:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the serialization logic for ManagedServiceIdentity to support the new MRW approach and the V3 format while also updating various test assets and related test code. Key changes include:

  • Updates to test asset JSON files (removing duplicate or extra closing brackets and fields).
  • Modifications in test helper methods and ManagedServiceIdentity serialization/deserialization logic to support V3 formatting.
  • Adjustments in test utilities and removal of obsolete tests.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/resourcemanager/Azure.ResourceManager/tests/Unit/TestAssets/Identity/*.json Removed extra or duplicate fields to correctly represent identity JSON structures
sdk/resourcemanager/Azure.ResourceManager/tests/Unit/ManagedServiceIdentityTest.cs Updated deserialization helper to support MRW and included string normalization changes
sdk/resourcemanager/Azure.ResourceManager/tests/Unit/JsonAsserts.cs Adjusted AssertConverterSerialization to work with IJsonModel and ModelReaderWriterOptions
sdk/resourcemanager/Azure.ResourceManager/tests/Scenario/PolicyAssignmentCollectionTests.cs Removed obsolete ManagedIdentity test cases
sdk/resourcemanager/Azure.ResourceManager/src/Common/Custom/Models/ManagedServiceIdentity.Serialization.cs Enhanced V3 handling and improved null handling for user assigned identities
sdk/resourcemanager/Azure.ResourceManager/src/Common/Custom/Models/AzureResourceManagerContext.cs Added builder registration for ManagedServiceIdentity

@live1206 live1206 enabled auto-merge (squash) June 20, 2025 03:46
@live1206 live1206 merged commit f0b3777 into Azure:main Jun 20, 2025
36 checks passed
@live1206 live1206 deleted the identity-type-v3 branch June 20, 2025 09:50
jsquire pushed a commit to JonathanCrd/azure-sdk-for-net that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants