Skip to content

Apply IJsonmodel<> changes from Azure.Core #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
live1206 merged 34 commits into from
Jul 16, 2025
Merged

Apply IJsonmodel<> changes from Azure.Core #5347

live1206 merged 34 commits into from
Jul 16, 2025

Conversation

@live1206
Copy link
Member

@live1206 live1206 commented Jun 13, 2025 •
edited
Loading

  • upgrade Azure.Core and Azure.Core.Expressions.DataFactory to the latest version to apply IJsonModel<> changes from Azure.Core
  • get rid of ManagedServiceIdentityTypeV3Converter.cs and remove it from shared file download
  • remove serialization helper methods from generated ModelSerializationExtensions.cs
  • make the generated code AOT compatible, the only exceptions are
    • use JsonSerializer.Serialize for BinaryData when .net version is under .net 6, which is not needed for AOT
    • use JsonSerializer.(De)serialize for DataFactory related types

live1206 added 26 commits May 28, 2025 17:22
@azure-sdk azure-sdk mentioned this pull request Jun 18, 2025
Closed
@live1206 live1206 marked this pull request as ready for review June 18, 2025 11:38
@live1206 live1206 requested a review from m-nash as a code owner June 18, 2025 11:38
@live1206
Copy link
Member Author

live1206 commented Jun 19, 2025 •
edited
Loading

pending on Azure/azure-sdk-for-net#50703
Also pending on Azure/azure-sdk-for-net#50705 to get beta version of Azure.ResourceManager to fix the CI

@live1206 live1206 mentioned this pull request Jun 19, 2025
Merged
@agocke
Copy link

agocke commented Jul 15, 2025

Is this ready for review?

@live1206
Copy link
Member Author

live1206 commented Jul 16, 2025 •
edited
Loading

Is this ready for review?

The SDK regen kept failing, there is no easy quick fix for now. Considering the priority of this, we will merge this and regen the SDK manually after the merge.

@live1206 live1206 merged commit f2fa136 into Azure:main Jul 16, 2025
8 checks passed
@live1206 live1206 deleted the apply-jsonmodel-azure-core branch July 17, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@live1206 @agocke @ArcturusZhang