Make scalers into per-task hub singletons #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachuv
approved these changes
Nov 21, 2024
cgillum
added a commit
that referenced
this pull request
Nov 26, 2024
This addresses an issue where the costs associated with polling storage resources increase substantially when an app has a large number of durable-trigger functions compared to apps that only have a small number.
nytian
pushed a commit
that referenced
this pull request
Nov 26, 2024
* Make scalers into per-task hub singletons (#2967) This addresses an issue where the costs associated with polling storage resources increase substantially when an app has a large number of durable-trigger functions compared to apps that only have a small number. * Remove unnecesary #ifdef * Update nuget package versions
This was referenced Dec 4, 2024
nytian
added a commit
that referenced
this pull request
Dec 5, 2024
* cherry pick change for sc * update version to rc.3 * remove warnings * cherry pick Use consistent scaler IDs for target-based and scale monitor implemen… --------- Co-authored-by: Chris Gillum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the efficiency of scale logic with the Azure Storage backend by creating a singleton scaler object for an entire task hub rather than having one per function, which is redundant since each scaler does the exact same work (regardless of function).
Resolves issue where storage costs increase dramatically when Scale Controller v3 is in use (same for when runtime-driven scaling is in use).
FYI @AnatoliB
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.cs