Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Enable Build Pipeline for nytian/dfv3-release-rc.2 #2983

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

nytian
Copy link
Collaborator

@nytian nytian commented Dec 4, 2024

This enables the build pipeline for nytian/dfv3-release-rc.2 to create a webjobs.extensions.durabletask-rc.3 private package with the hotfix for Scale Controller. Our official webjobs.extensions.durabletask v3.x no longer supports .NET Standard 2.0, but Scale Controller v3.x still requires it. Thus we need to use branch nytian/dfv3-release-rc.2 to build the hotfix package.

This is a temporary change and should be revert back later after build.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

@nytian nytian requested review from andystaples and bachuv December 4, 2024 19:44
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that I have a change in the v3.x branch that changes the implementation of the DurableEntity_AsyncIO test in a way that should make it more reliable.

@nytian nytian merged commit 04665e7 into dev Dec 4, 2024
5 of 6 checks passed
@nytian nytian deleted the nytian/add-rc.2branch-to-build branch December 4, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants