Skip to content

revert: [NPM] Remove hostUsers Configuration #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions .pipelines/npm/npm-conformance-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ stages:
IS_STRESS_TEST: "false"
v2-linux-stress:
AZURE_CLUSTER: "conformance-v2-linux-stress"
PROFILE: "v2-background"
PROFILE: "v2-linux-stress"
IS_STRESS_TEST: "true"
v2-place-first:
AZURE_CLUSTER: "conformance-v2-place-first"
Expand All @@ -123,6 +123,7 @@ stages:
RESOURCE_GROUP: $[ stagedependencies.setup.setup.outputs['EnvironmentalVariables.RESOURCE_GROUP'] ]
TAG: $[ stagedependencies.setup.setup.outputs['EnvironmentalVariables.TAG'] ]
FQDN: empty
PUBLIC_IP_NAME: $(RESOURCE_GROUP)-$(PROFILE)-public-ip
steps:
- checkout: self

Expand All @@ -137,6 +138,23 @@ stages:
echo created RG $(RESOURCE_GROUP) in $(LOCATION)
az version

- task: AzureCLI@2
displayName: "Create public IP with a service tag"
inputs:
azureSubscription: $(BUILD_VALIDATIONS_SERVICE_CONNECTION)
scriptType: "bash"
scriptLocation: "inlineScript"
inlineScript: |
az network public-ip create \
--name $(PUBLIC_IP_NAME) \
--resource-group $(RESOURCE_GROUP) \
--allocation-method Static \
--ip-tags 'FirstPartyUsage=/DelegatedNetworkControllerTest' \
--location $(LOCATION) \
--sku Standard \
--tier Regional \
--version IPv4

- task: AzureCLI@2
displayName: "Deploy NPM to Test Cluster"
inputs:
Expand All @@ -150,6 +168,9 @@ stages:
chmod +x kubectl
echo Cluster $(AZURE_CLUSTER)
echo Resource $(RESOURCE_GROUP)
echo Public IP $(PUBLIC_IP_NAME)
export PUBLIC_IP_ID=$(az network public-ip show -g $(RESOURCE_GROUP) -n $(PUBLIC_IP_NAME) --query id -o tsv)
echo Public IP ID $PUBLIC_IP_ID

if [[ $(AZURE_CLUSTER) == *ws22 ]] # * is used for pattern matching
then
Expand All @@ -166,7 +187,8 @@ stages:
--network-plugin azure \
--vm-set-type VirtualMachineScaleSets \
--node-vm-size Standard_D4s_v3 \
--node-count 1
--node-count 1 \
--load-balancer-outbound-ips $PUBLIC_IP_ID

if [ $? != 0 ]
then
Expand Down Expand Up @@ -213,7 +235,8 @@ stages:
az aks create --no-ssh-key \
--resource-group $(RESOURCE_GROUP) \
--name $(AZURE_CLUSTER) \
--network-plugin azure
--network-plugin azure \
--load-balancer-outbound-ips $PUBLIC_IP_ID

if [ $? != 0 ]
then
Expand Down
16 changes: 15 additions & 1 deletion .pipelines/npm/npm-scale-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,19 @@ jobs:
echo "Creating resource group named $(RESOURCE_GROUP)"
az group create --name $(RESOURCE_GROUP) -l $(LOCATION) -o table

export PUBLIC_IP_NAME=$(RESOURCE_GROUP)-$(PROFILE)-public-ip
echo "Creating public IP with a service tag named $PUBLIC_IP_NAME"
az network public-ip create \
--name $PUBLIC_IP_NAME \
--resource-group $(RESOURCE_GROUP) \
--allocation-method Static \
--ip-tags 'FirstPartyUsage=/DelegatedNetworkControllerTest' \
--location $(LOCATION) \
--sku Standard \
--tier Regional \
--version IPv4
export PUBLIC_IP_ID=$(az network public-ip show -g $(RESOURCE_GROUP) -n $PUBLIC_IP_NAME --query id -o tsv)

export CLUSTER_NAME=$(RESOURCE_GROUP)-$(PROFILE)
echo "Creating cluster named $CLUSTER_NAME"
az aks create \
Expand All @@ -152,7 +165,8 @@ jobs:
--node-vm-size Standard_D4s_v3 \
--node-count 1 \
--tier standard \
--max-pods 100
--max-pods 100 \
--load-balancer-outbound-ips $PUBLIC_IP_ID

echo "Getting credentials to $CLUSTER_NAME"
az aks get-credentials -g $(RESOURCE_GROUP) -n $CLUSTER_NAME --overwrite-existing --file ./kubeconfig
Expand Down
1 change: 0 additions & 1 deletion npm/azure-npm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ spec:
- name: tmp
mountPath: /tmp
hostNetwork: true
hostUsers: false
nodeSelector:
kubernetes.io/os: linux
volumes:
Expand Down
1 change: 0 additions & 1 deletion npm/examples/azure-npm-lite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ spec:
- name: tmp
mountPath: /tmp
hostNetwork: true
hostUsers: false
nodeSelector:
kubernetes.io/os: linux
volumes:
Expand Down
Loading