revert: [NPM] Remove hostUsers Configuration #3612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request reverts a previous change that removed the hostUsers configuration in the NPM daemonset, thereby restoring compatibility with user namespace restrictions when using hostNetwork.
- Reverts removal of "hostUsers: false" in both azure-npm-lite.yaml and azure-npm.yaml
- Restores original daemonset settings to comply with Kubernetes pod user namespace requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| npm/examples/azure-npm-lite.yaml | Re-added "hostUsers: false" to revert previous changes |
| npm/azure-npm.yaml | Re-added "hostUsers: false" to revert previous changes |
|
/azp run Azure Container Networking PR |
|
No pipelines are associated with this pull request. |
|
/azp run Azure Container Networking PR |
|
/azp run NPM Conformance Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run NPM Scale Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
huntergregory
previously approved these changes
Apr 29, 2025
vakalapa
previously approved these changes
Apr 29, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes the
hostUsers: falsesetting in the NPM daemonset. Reverts from changes #2589Also adds a public-ip and service tag to NPM scale and conformance tests to comply with SFI rules (failing with
RequestDisallowedByPolicyotherwise).Issue Fixed:
From https://kubernetes.io/docs/concepts/workloads/pods/user-namespaces/#limitations
When using a user namespace for the pod, it is disallowed to use other host namespaces. In particular, if you set
hostUsers: falsethen you are not allowed to set any of:Requirements:
Notes: