Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing #131 #132

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fixing #131 #132

merged 1 commit into from
Jul 24, 2023

Conversation

cmendible
Copy link
Member

Description

Tag rules only check len(c.Tags) == 0 instead of checking c.Tags == nil || len(c.Tags) == 0 since len(nil value) = 0 in go

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #131

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@cmendible cmendible merged commit bfb6a73 into main Jul 24, 2023
11 checks passed
@cmendible cmendible deleted the issue-131 branch July 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachoalonsoportillo nachoalonsoportillo Awaiting requested review from nachoalonsoportillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tag rules.
1 participant
@cmendible