Skip to content

Commit

Permalink
fixing #131
Browse files Browse the repository at this point in the history
  • Loading branch information
cmendible committed Jul 24, 2023
1 parent 10c29aa commit bfb6a73
Show file tree
Hide file tree
Showing 28 changed files with 34 additions and 34 deletions.
2 changes: 1 addition & 1 deletion internal/scanners/afd/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (a *FrontDoorScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcdn.Profile)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/afw/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (a *FirewallScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.AzureFirewall)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/agw/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (a *ApplicationGatewayScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.ApplicationGateway)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/aks/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func (a *AKSScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcontainerservice.ManagedCluster)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/apim/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func (a *APIManagementScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armapimanagement.ServiceResource)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/appcs/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (a *AppConfigurationScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappconfiguration.ConfigurationStore)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/appi/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (a *AppInsightsScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armapplicationinsights.Component)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/cae/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (a *ContainerAppsScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappcontainers.ManagedEnvironment)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/ci/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (a *ContainerInstanceScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcontainerinstance.ContainerGroup)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/cog/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (a *CognitiveScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcognitiveservices.Account)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/cosmos/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (a *CosmosDBScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcosmos.DatabaseAccountGetResults)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/cr/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (a *ContainerRegistryScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcontainerregistry.Registry)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/evgd/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (a *EventGridScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armeventgrid.Domain)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/evh/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (a *EventHubScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armeventhub.EHNamespace)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/kv/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (a *KeyVaultScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armkeyvault.Vault)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/lb/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func (a *LoadBalancerScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.LoadBalancer)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
4 changes: 2 additions & 2 deletions internal/scanners/mysql/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func (a *MySQLScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armmysql.Server)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -197,7 +197,7 @@ func (a *MySQLFlexibleScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armmysqlflexibleservers.Server)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
6 changes: 3 additions & 3 deletions internal/scanners/plan/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (a *AppServiceScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Plan)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -158,7 +158,7 @@ func (a *AppServiceScanner) GetAppRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Site)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -228,7 +228,7 @@ func (a *AppServiceScanner) GetFunctionRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armappservice.Site)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
4 changes: 2 additions & 2 deletions internal/scanners/psql/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (a *PostgreScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armpostgresql.Server)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -211,7 +211,7 @@ func (a *PostgreFlexibleScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armpostgresqlflexibleservers.Server)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/redis/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (a *RedisScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armredis.ResourceInfo)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/sb/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func (a *ServiceBusScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armservicebus.SBNamespace)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/sigr/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (a *SignalRScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armsignalr.ResourceInfo)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
4 changes: 2 additions & 2 deletions internal/scanners/sql/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (a *SQLScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armsql.Server)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -155,7 +155,7 @@ func (a *SQLScanner) GetDatabaseRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armsql.Database)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/st/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (a *StorageScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armstorage.Account)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/vm/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (a *VirtualMachineScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armcompute.VirtualMachine)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
4 changes: 2 additions & 2 deletions internal/scanners/vnet/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (a *VirtualNetworkScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.VirtualNetwork)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down Expand Up @@ -91,7 +91,7 @@ func (a *VirtualNetworkScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityHigh,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.VirtualNetwork)
if c.Properties.DhcpOptions == nil {
if c.Properties.DhcpOptions == nil {
return false, ""
}
return len(c.Properties.DhcpOptions.DNSServers) < 2, ""
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/vwan/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (a *VirtualWanScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armnetwork.VirtualWAN)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down
2 changes: 1 addition & 1 deletion internal/scanners/wps/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func (a *WebPubSubScanner) GetRules() map[string]scanners.AzureRule {
Severity: scanners.SeverityLow,
Eval: func(target interface{}, scanContext *scanners.ScanContext) (bool, string) {
c := target.(*armwebpubsub.ResourceInfo)
return c.Tags == nil || len(c.Tags) == 0, ""
return len(c.Tags) == 0, ""
},
Url: "https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json",
},
Expand Down

0 comments on commit bfb6a73

Please sign in to comment.