-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use env
node for all IS_DEV_BUILD
CI assignments
#1007
Draft
mokagio
wants to merge
1
commit into
trunk
Choose a base branch
from
mokagio/is-dev-build-env-ci
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,6 @@ steps: | |
command: | | ||
# call with bash explicitly because we run this on Windows, too | ||
bash .buildkite/commands/install-node-dependencies.sh | ||
export IS_DEV_BUILD=true | ||
echo '--- :package: Package app for testing' | ||
npm run package | ||
echo '--- :playwright: Run End To End Tests' | ||
|
@@ -67,6 +66,7 @@ steps: | |
env: | ||
# See https://playwright.dev/docs/ci#debugging-browser-launches | ||
DEBUG: "pw:browser" | ||
IS_DEV_BUILD: true | ||
matrix: | ||
- mac | ||
#- windows | ||
|
@@ -87,8 +87,6 @@ steps: | |
|
||
node ./scripts/prepare-dev-build-version.mjs | ||
|
||
export IS_DEV_BUILD=true | ||
|
||
echo "--- :node: Building Binary" | ||
npm run make:macos-{{matrix}} | ||
|
||
|
@@ -113,6 +111,8 @@ steps: | |
|
||
echo "--- 📃 Notarizing Binary" | ||
bundle exec fastlane notarize_binary | ||
env: | ||
IS_DEV_BUILD: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN] | ||
artifact_paths: | ||
- out/**/*.app.zip | ||
|
@@ -158,15 +158,15 @@ steps: | |
|
||
.buildkite/commands/install-node-dependencies.sh | ||
|
||
export IS_DEV_BUILD=true | ||
|
||
echo "--- :node: Generating Release Manifest" | ||
node ./scripts/prepare-dev-build-version.mjs | ||
node ./scripts/generate-releases-manifest.mjs | ||
|
||
echo "--- :fastlane: Distributing Dev Builds" | ||
install_gems | ||
bundle exec fastlane distribute_dev_build | ||
env: | ||
IS_DEV_BUILD: true | ||
artifact_paths: | ||
- out/releases.json | ||
agents: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm... in the E2E on the
mac
queue,IS_DEV_BUILD
istrue
in the environment tab, but the build process mustn't be reading it as such, because the Sentry log check reads "production"See bottom of the list here:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the packaging steps below correctly send the env var to the Mac VM, my current guess is that the issue here has to do with how the E2E tests are scripted.
Will look into it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd... If I run with
IS_DEV_BUILD=true
on my local, I get sentry development as expected.Also had to
export DEBUG=pw:browser
" to see the sentry logs.cc @wojtekn any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable is read in the Electron app via
process.env.IS_DEV_BUILD
to decide whether Sentry should be initialized or not. It seems that when the environment variable is set inenv:
section, it's not available in the Studio process launched by E2E.If we want to remove it from the command section, what if we set it explicitly in the
package.json
where we definee2e
script? We do the same for other environment variables with other scripts there.