Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env node for all IS_DEV_BUILD CI assignments #1007

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Use env node for all IS_DEV_BUILD CI assignments #1007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ steps:
command: |
# call with bash explicitly because we run this on Windows, too
bash .buildkite/commands/install-node-dependencies.sh
export IS_DEV_BUILD=true
echo '--- :package: Package app for testing'
npm run package
echo '--- :playwright: Run End To End Tests'
Expand All @@ -67,6 +66,7 @@ steps:
env:
# See https://playwright.dev/docs/ci#debugging-browser-launches
DEBUG: "pw:browser"
IS_DEV_BUILD: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm... in the E2E on the mac queue, IS_DEV_BUILD is true in the environment tab, but the build process mustn't be reading it as such, because the Sentry log check reads "production"

See bottom of the list here:
image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the packaging steps below correctly send the env var to the Mac VM, my current guess is that the issue here has to do with how the E2E tests are scripted.

Will look into it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd... If I run with IS_DEV_BUILD=true on my local, I get sentry development as expected.

image

Also had to export DEBUG=pw:browser" to see the sentry logs.

cc @wojtekn any ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is read in the Electron app via process.env.IS_DEV_BUILD to decide whether Sentry should be initialized or not. It seems that when the environment variable is set in env: section, it's not available in the Studio process launched by E2E.

If we want to remove it from the command section, what if we set it explicitly in the package.json where we define e2e script? We do the same for other environment variables with other scripts there.

matrix:
- mac
#- windows
Expand All @@ -87,8 +87,6 @@ steps:

node ./scripts/prepare-dev-build-version.mjs

export IS_DEV_BUILD=true

echo "--- :node: Building Binary"
npm run make:macos-{{matrix}}

Expand All @@ -113,6 +111,8 @@ steps:

echo "--- 📃 Notarizing Binary"
bundle exec fastlane notarize_binary
env:
IS_DEV_BUILD: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay in universal

image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay in x64

image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay in arm64
image

image

plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
artifact_paths:
- out/**/*.app.zip
Expand Down Expand Up @@ -158,15 +158,15 @@ steps:

.buildkite/commands/install-node-dependencies.sh

export IS_DEV_BUILD=true

echo "--- :node: Generating Release Manifest"
node ./scripts/prepare-dev-build-version.mjs
node ./scripts/generate-releases-manifest.mjs

echo "--- :fastlane: Distributing Dev Builds"
install_gems
bundle exec fastlane distribute_dev_build
env:
IS_DEV_BUILD: true
artifact_paths:
- out/releases.json
agents:
Expand Down
Loading