Use env node for all IS_DEV_BUILD CI assignments
#1007
Conversation
In #998 (comment) I got confirmation that it's okay to use this approach for the env var setting. Given it's already in use, because it would not work otherwise, in the Windows steps, this commit updates all the other steps so we have a consistent setup.
| @@ -67,6 +66,7 @@ steps: | |||
| env: | |||
| # See https://playwright.dev/docs/ci#debugging-browser-launches | |||
| DEBUG: "pw:browser" | |||
| IS_DEV_BUILD: true | |||
There was a problem hiding this comment.
Mmm... in the E2E on the mac queue, IS_DEV_BUILD is true in the environment tab, but the build process mustn't be reading it as such, because the Sentry log check reads "production"
See bottom of the list here:
There was a problem hiding this comment.
Given the packaging steps below correctly send the env var to the Mac VM, my current guess is that the issue here has to do with how the E2E tests are scripted.
Will look into it...
There was a problem hiding this comment.
Odd... If I run with IS_DEV_BUILD=true on my local, I get sentry development as expected.
Also had to export DEBUG=pw:browser" to see the sentry logs.
cc @wojtekn any ideas?
There was a problem hiding this comment.
The variable is read in the Electron app via process.env.IS_DEV_BUILD to decide whether Sentry should be initialized or not. It seems that when the environment variable is set in env: section, it's not available in the Studio process launched by E2E.
If we want to remove it from the command section, what if we set it explicitly in the package.json where we define e2e script? We do the same for other environment variables with other scripts there.
| @@ -113,6 +111,8 @@ steps: | |||
|
|
|||
| echo "--- 📃 Notarizing Binary" | |||
| bundle exec fastlane notarize_binary | |||
| env: | |||
| IS_DEV_BUILD: true | |||
Related issues
Proposed Changes
Always use
env: IS_DEV_BUILD: truein CI to set theIS_DEV_BUILDenv var.In #998 (comment) I got confirmation that it's okay to use this approach for the env var setting.
Given it's already in use, because it would not work otherwise, in the Windows steps, this commit updates all the other steps so we have a consistent setup.
Testing Instructions
Pre-merge Checklist