Fix deprecation notices on PHP 8.2 #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
force-pushed
the
fix/deprecation-notices
branch
from
0366ef2
to
389c765
Compare
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
|
Test the previous changes of this PR with WordPress Playground. |
m1r0
commented
Jul 31, 2024
Comment on lines
+349
to
+351
| ob_start(); | ||
| Sensei()->setup_wizard->render_wizard_page(); | ||
| ob_end_clean(); |
There was a problem hiding this comment.
This prevents an annoying output when running the test.
There was a problem hiding this comment.
Special thanks for this one 😅
m1r0
commented
Jul 31, 2024
| } | ||
|
|
||
| /** | ||
| * Enqueue the global block assets, except when the user is on the admin page. | ||
| */ | ||
| public function testEnqueueBlockAssets_WhenCalledOnAdmin_NotEnqueueCourseListFilter() { | ||
| /* Arrange */ | ||
|
|
||
| $this->markTestSkipped( 'This test requires WordPress 5.8 or higher.' ); |
There was a problem hiding this comment.
This test was waiting for a minimum supported WP version higher than 5.8, which we now have.
m1r0
commented
Jul 31, 2024
| Significance: patch | ||
| Type: fixed | ||
|
|
||
| Deprecation notice on the reports screen when using PHP 8.1 |
There was a problem hiding this comment.
Having one changelog for the deprecation notices might be better because there are so many.
merkushin
previously approved these changes
Jul 31, 2024
includes/rest-api/class-sensei-rest-api-course-progress-controller.php
Outdated
Show resolved
Hide resolved
includes/rest-api/class-sensei-rest-api-course-students-controller.php
Outdated
Show resolved
Hide resolved
|
Test the previous changes of this PR with WordPress Playground. |
This was
linked to
issues
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7633, #7634, #7635
Proposed Changes
Testing Instructions
define( 'WP_DEBUG_DISPLAY', true );anddefine( 'WP_DEBUG_LOG', true );in wp-config.php.debug.logfile and make sure there are no errors related to sensei-pro. Note that there could be some related to Sensei core which will be addressed in another PR.Pre-Merge Checklist