Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Sensei and Sensei Pro on PHP 8.1 #7634

Closed
donnapep opened this issue Jul 19, 2024 · 2 comments · Fixed by #7644, #7645 or #7650
Closed

Test Sensei and Sensei Pro on PHP 8.1 #7634

donnapep opened this issue Jul 19, 2024 · 2 comments · Fixed by #7644, #7645 or #7650
Assignees
@m1r0
Labels
[Pri] High Ship ASAP [Status] Triaged Issue has been triaged
Milestone
4.24.2

Comments

@donnapep
Copy link
Collaborator

  • Add define( 'WP_DEBUG_DISPLAY', true ); in wp-config.php.
  • Test all Sensei or Sensei Pro specific functionality on PHP 8.1.
  • Fix any PHP notices / errors / warnings displayed in WP admin or on the frontend.
@donnapep donnapep added [Type] Bug [Status] Triaged Issue has been triaged labels Jul 19, 2024
@donnapep donnapep added this to the 4.24.2 milestone Jul 19, 2024
@donnapep donnapep added [Pri] Normal Can wait for the next release and removed [Type] Bug labels Jul 19, 2024
@renatho
Copy link
Contributor

renatho commented Jul 24, 2024

It's probably worth already check it in PHP 8.2. From this, I noticed we have many deprecation notices with PHP 8.2. Reproduced locally.

This was referenced Jul 29, 2024
Merged
Merged
@m1r0 m1r0 self-assigned this Jul 29, 2024
@donnapep
Copy link
Collaborator Author

donnapep commented Jul 29, 2024 •
edited
Loading

It's probably worth already check it in PHP 8.2. From this, I noticed we have many deprecation notices with PHP 8.2. Reproduced locally.

@renatho There's a separate issue for PHP 8.2. 🙂

@donnapep donnapep added [Pri] High Ship ASAP and removed [Pri] Normal Can wait for the next release labels Jul 29, 2024
@m1r0 m1r0 mentioned this issue Jul 31, 2024
Merged
15 tasks
@m1r0 m1r0 closed this as completed Aug 1, 2024
This was linked to pull requests Aug 2, 2024
Fix deprecation notice when passing NULL to wp_kses_post on the reports screen #7644
Merged
Fix deprecation notice on the question edit screen on PHP 8.1 #7645
Merged
Fix deprecation notices on PHP 8.2 #7650
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m1r0 m1r0

Labels
[Pri] High Ship ASAP [Status] Triaged Issue has been triaged
Projects
None yet
Milestone
4.24.2
3 participants
@renatho @donnapep @m1r0